no longer accept rest at objects.delete

Author: joaotonaco

.changeset/big-houses-taste.md

@@ -0,0 +1,5 @@
+---
+"@squarecloud/blob": patch
+---
+
+No longer accept rest arrays at `objects.delete`

src/managers/api.ts

@@ -31,13 +31,13 @@ export class APIManager {
 					.filter(([, value]) => Boolean(value))
 					.map(([key, value]) => [key, String(value)]),
 			);
-		const params = new URLSearchParams(paramsObject).toString();
+		const params = new URLSearchParams(paramsObject);
+
+		const { params: _, headers, body, ...rest } = options;
 
-		const { method, headers, body, ...rest } = options;
 		const init: RequestInit = {
-			method: method || "GET",
-			headers: { Authorization: this.apiKey, ...(headers || {}) },
 			...rest,
+			headers: { ...(headers || {}), Authorization: this.apiKey },
 		};
 
 		if (body) {

src/managers/objects.ts

@@ -2,7 +2,6 @@ import type { SquareCloudBlob } from "..";
 import { BlobObject } from "../structures/object";
 import type { CreateObjectResponse, CreateObjectType } from "../types/create";
 import type { ListObjectsResponse } from "../types/list";
-import { MimeTypeUtil } from "../utils/mimetype";
 import { parsePathLike } from "../utils/path-like";
 import { assertCreateObjectResponse } from "../validation/assertions/create";
 import { assertListObjectsResponse } from "../validation/assertions/list";
@@ -16,7 +15,7 @@ export class ObjectsManager {
 	 *
 	 * @example
 	 * ```js
-	 * const objects = await blob.objects.list();
+	 * blob.objects.list();
 	 * ```
 	 */
 	async list() {
@@ -28,17 +27,19 @@ export class ObjectsManager {
 			return [];
 		}
 
-		return list.objects.map(
-			(object) =>
-				new BlobObject({
-					idOrUrl: object.id,
-					size: object.size,
-					createdAt: new Date(object.created_at),
-					expiresAt: object.expires_at
-						? new Date(object.expires_at)
-						: undefined,
-				}),
-		);
+		return list.objects.map((objectData) => {
+			const createdAt = new Date(objectData.created_at);
+			const expiresAt = objectData.expires_at
+				? new Date(objectData.expires_at)
+				: undefined;
+
+			return new BlobObject({
+				idOrUrl: objectData.id,
+				size: objectData.size,
+				createdAt,
+				expiresAt,
+			});
+		});
 	}
 
 	/**
@@ -48,27 +49,31 @@ export class ObjectsManager {
 	 *
 	 * @example
 	 * ```js
-	 * await blob.objects.create({ file: "path/to/file.jpeg", name: "my_image" });
+	 * // Basic usage with absolute path
+	 * blob.objects.create({
+	 * 	file: "path/to/file.jpeg",
+	 * 	name: "my_image"
+	 * });
+	 *
+	 * // Advanced usage with Buffer
+	 * blob.objects.create({
+	 * 	file: Buffer.from("content"),
+	 * 	name: "my_image",
+	 * 	mimeType: "image/jpeg"
+	 * })
 	 * ```
 	 */
 	async create(object: CreateObjectType) {
 		const payload = createObjectPayloadSchema.parse(object);
 		const file = await parsePathLike(payload.file);
-		const mimeType =
-			typeof object.file === "string"
-				? MimeTypeUtil.fromExtension(object.file.split(".")[1])
-				: object.mimeType;
+		const type = payload.mimeType || object.mimeType;
 
 		const formData = new FormData();
-		formData.append("file", new Blob([file], { type: mimeType }));
+		formData.append("file", new Blob([file], { type }));
 
 		const { response } = await this.client.api.request<CreateObjectResponse>(
 			"objects",
-			{
-				method: "POST",
-				body: formData,
-				params: payload.params,
-			},
+			{ method: "POST", body: formData, params: payload.params },
 		);
 
 		const objectData = assertCreateObjectResponse(response);
@@ -86,15 +91,16 @@ export class ObjectsManager {
 	 *
 	 * @example
 	 * ```js
-	 * await blob.objects.delete("ID/prefix/name1_xxx-xxx.mp4", "ID/prefix/name_xxx-xxx-xxx.png");
+	 * blob.objects.delete([
+	 * 	"userId/prefix/name1_xxx-xxx.mp4",
+	 * 	"userId/prefix/name_xxx-xxx-xxx.png"
+	 * ]);
 	 * ```
 	 */
-	async delete(...objects: string[] | string[][]) {
-		const ids = objects.flat();
-
+	async delete(objects: string[]) {
 		const { status } = await this.client.api.request("objects", {
 			method: "DELETE",
-			body: { objects: ids },
+			body: { objects },
 		});
 
 		return status === "success";

src/validation/schemas/create.ts

@@ -27,6 +27,10 @@ export const createObjectSchema = z
 export const createObjectPayloadSchema = createObjectSchema.transform(
 	({ file, securityHash, autoDownload, expiresIn, ...rest }) => ({
 		file,
+		mimeType:
+			typeof file === "string"
+				? MimeTypeUtil.fromExtension(file.split(".")[1])
+				: undefined,
 		params: {
 			...rest,
 			expire: expiresIn,