-
Notifications
You must be signed in to change notification settings - Fork 9
TopoViewer Grid: unified manager, UI line width control, and persistent viewer settings #421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
asadarafat
wants to merge
21
commits into
srl-labs:main
Choose a base branch
from
asadarafat:topoviewer-gridguide-refactor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
TopoViewer Grid: unified manager, UI line width control, and persistent viewer settings #421
asadarafat
wants to merge
21
commits into
srl-labs:main
from
asadarafat:topoviewer-gridguide-refactor
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ix duplicate bridge interfaces
…o duplicate-interface auto-fi
…ML/annotations so no need reload to see the correct numbering
…ias group is detected, to make the behavior explicit.
…de; dedupe colors; align spacing
…as labels; edge rewiring; cleanup - Persist bridge alias label with per-interface identity (id = yamlNodeId:yamlInterface) - Rebuild alias nodes from nodeAnnotations and rewire edges deterministically by interface - Remove legacy aliasEndpointAnnotations on save; keep legacy read as fallback - Save/merge annotations synthesized from edges to ensure all alias interfaces persist - Refactor + lint fixes to reduce complexity
…sEndpointAnnotations
…t in annotations - Webview: on paste, set extraData.copyFrom to the source Cytoscape node id - Save: write nodeAnnotations.copyFrom, resolving to a stable annotation id for bridge aliases (yamlNodeId:yamlInterface) when possible - Types: document copyFrom as one-hop provenance only; never affects wiring/rewiring - Refactor paste code to extract provenance helper and reduce complexity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What’s Included
dedupe theme colors and align default spacing.
overlay and plugin visuals immediately.
Motivation
annotations.
Developer Notes
Testing Instructions
CleanShot.2025-10-26.at.22.13.52.mp4
Compatibility / Migration
viewerSettings as needed.
the setting.
Housekeeping