From 18f8bfd741be14a776932b0a3d17d18ff6f932d2 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Sat, 1 Oct 2022 11:24:38 +0000 Subject: [PATCH 1/2] Adding tarfile member sanitization to extractall() --- src/v8/test/benchmarks/testcfg.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/src/v8/test/benchmarks/testcfg.py b/src/v8/test/benchmarks/testcfg.py index c94a35ffd9..90a826feed 100755 --- a/src/v8/test/benchmarks/testcfg.py +++ b/src/v8/test/benchmarks/testcfg.py @@ -147,7 +147,26 @@ def _DownloadIfNecessary(self, url, revision, target_dir): archive_file = "downloaded_%s_%s.tar.gz" % (target_dir, revision) if os.path.exists(archive_file): with tarfile.open(archive_file, "r:gz") as tar: - tar.extractall() + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner) + + + safe_extract(tar) with open(revision_file, "w") as f: f.write(revision) return From dcb56f7b6aadd984b8262e697f2fd0b9863ae3c5 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Tue, 4 Oct 2022 04:37:08 +0000 Subject: [PATCH 2/2] Adding numeric_owner as keyword arguement --- src/v8/test/benchmarks/testcfg.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/v8/test/benchmarks/testcfg.py b/src/v8/test/benchmarks/testcfg.py index 90a826feed..f26e717131 100755 --- a/src/v8/test/benchmarks/testcfg.py +++ b/src/v8/test/benchmarks/testcfg.py @@ -163,7 +163,7 @@ def safe_extract(tar, path=".", members=None, *, numeric_owner=False): if not is_within_directory(path, member_path): raise Exception("Attempted Path Traversal in Tar File") - tar.extractall(path, members, numeric_owner) + tar.extractall(path, members, numeric_owner=numeric_owner) safe_extract(tar)