Merge pull request #108 from W0rma/symfony8

Add support for symfony 8

Author: stecman

composer.json

@@ -10,7 +10,7 @@
     ],
     "require": {
         "php": ">=8.1",
-        "symfony/console": "~6.4 || ^7.1"
+        "symfony/console": "~6.4 || ^7.1 || ^8.0"
     },
     "require-dev": {
         "phpunit/phpunit": "^9.5",

src/CompletionCommand.php

@@ -15,7 +15,7 @@ class CompletionCommand extends SymfonyCommand
      */
     protected $handler;
 
-    protected function configure()
+    protected function configure(): void
     {
         $this
             ->setName('_completion')

tests/Stecman/Component/Symfony/Console/BashCompletion/Common/CompletionHandlerTestCase.php

@@ -39,7 +39,12 @@ protected function setUp(): void
         ));
 
         if (method_exists('\HiddenCommand', 'setHidden')) {
-            $this->application->add(new \HiddenCommand());
+            // Added in symfony 7.4
+            if (method_exists($this->application, 'addCommand')) {
+                $this->application->addCommand(new \HiddenCommand());
+            } else {
+                $this->application->add(new \HiddenCommand());
+            }
         }
     }
 

tests/Stecman/Component/Symfony/Console/BashCompletion/CompletionCommandTest.php

@@ -30,7 +30,12 @@ public function testConflictingGlobalOptions()
             new InputOption('program', null, InputOption::VALUE_REQUIRED)
         );
 
-        $app->add(new CompletionCommand());
+        // Added in symfony 7.4
+        if (method_exists($app, 'addCommand')) {
+            $app->addCommand(new CompletionCommand());
+        } else {
+            $app->add(new CompletionCommand());
+        }
 
         // Check completion command doesn't throw
         $app->doRun(new StringInput('_completion -g --program foo'), new NullOutput());

tests/Stecman/Component/Symfony/Console/BashCompletion/Fixtures/CompletionAwareCommand.php

@@ -9,7 +9,7 @@
 
 class CompletionAwareCommand extends Command implements CompletionAwareInterface
 {
-    protected function configure()
+    protected function configure(): void
     {
         $this->setName('completion-aware')
             ->addOption('option-with-suggestions', null, InputOption::VALUE_REQUIRED)

tests/Stecman/Component/Symfony/Console/BashCompletion/Fixtures/HiddenCommand.php

@@ -4,7 +4,7 @@
 
 class HiddenCommand extends Command
 {
-    protected function configure()
+    protected function configure(): void
     {
         $this->setName('internals')
             ->setHidden(true);

tests/Stecman/Component/Symfony/Console/BashCompletion/Fixtures/TestBasicCommand.php

@@ -6,7 +6,7 @@
 
 class TestBasicCommand extends Command
 {
-    protected function configure()
+    protected function configure(): void
     {
         $this->setName('wave')
             ->addOption(

tests/Stecman/Component/Symfony/Console/BashCompletion/Fixtures/TestSymfonyStyleCommand.php

@@ -5,7 +5,7 @@
 
 class TestSymfonyStyleCommand extends Command
 {
-    protected function configure()
+    protected function configure(): void
     {
         $this->setName('walk:north')
             ->addOption(