Skip to content

UpdateProps of community settings is rejected by Hivemind as invalid #3932

@only-dev-time

Description

@only-dev-time

Updating the community props with custom_json op contains the field settings which is an empty object if no image has been set.

Example

Mention by user: https://steemit.com/@event-horizon/sp64bx
Transaction: https://steemworld.org/block/91602709/91602709-13
grafik

Hivemind

Hivemind doesn't accept empty objects in the fields:

INFO:hive.indexer.community:validating @hive-117153 op ['updateProps', {'community': 'hive-117153', 'props': {'title': 'ارتقاء', 'about': 'Invitation only community for progressive desi.', 'settings': {}, 'is_nsfw': False, 'lang': 'en', 'description': '', 'flag_text': ''}}]
WARNING:hive.indexer.notify:[NOTIFY] error - src None dst 1923595 pid None (key `settings` was blank) cid None (35/100)

link to the check: https://github.com/only-dev-time/hivemind/blob/33204e1c2a18551acdb60e0a6142d1e2a4983d71/hive/indexer/community.py#L89

Analysis

With #3927 in SettingsEditButton.jsx the field settings was added to the props for the custom_json:
only-dev-time@0da5aa3#diff-0b3b832a35933fe6e6ab1230a31131d076a671c39806fc56863578bcdcb39e83R100

@the-gorilla-steem Could a check that no images has been set solve the problem?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions