Skip to content

Commit 0e3f23d

Browse files
committed
reorganize classes so test data is separate from test cases
1 parent 974a5f7 commit 0e3f23d

16 files changed

+44
-30
lines changed

src/test/java/org/json/junit/EnumTest.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@
1010

1111
import org.json.JSONArray;
1212
import org.json.JSONObject;
13+
import org.json.junit.data.MyEnum;
14+
import org.json.junit.data.MyEnumClass;
15+
import org.json.junit.data.MyEnumField;
1316
import org.junit.Test;
1417

1518
import com.jayway.jsonpath.Configuration;
@@ -195,7 +198,7 @@ public void enumValueToString() {
195198
* However, an enum within another class will not be rendered
196199
* unless that class overrides default toString()
197200
*/
198-
String expectedStr3 = "\"org.json.junit.MyEnumClass@";
201+
String expectedStr3 = "\"org.json.junit.data.MyEnumClass@";
199202
myEnumClass.setMyEnum(MyEnum.VAL1);
200203
myEnumClass.setMyEnumField(MyEnumField.VAL1);
201204
String str3 = JSONObject.valueToString(myEnumClass);

src/test/java/org/json/junit/JSONObjectLocaleTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import java.util.*;
66

77
import org.json.*;
8+
import org.json.junit.data.MyLocaleBean;
89
import org.junit.*;
910

1011
/**

src/test/java/org/json/junit/JSONObjectTest.java

Lines changed: 11 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,16 @@
3030
import org.json.JSONObject;
3131
import org.json.JSONPointerException;
3232
import org.json.XML;
33+
import org.json.junit.data.BrokenToString;
34+
import org.json.junit.data.Fraction;
35+
import org.json.junit.data.MyBean;
36+
import org.json.junit.data.MyBigNumberBean;
37+
import org.json.junit.data.MyEnum;
38+
import org.json.junit.data.MyEnumField;
39+
import org.json.junit.data.MyJsonString;
40+
import org.json.junit.data.MyNumber;
41+
import org.json.junit.data.MyNumberContainer;
42+
import org.json.junit.data.MyPublicClass;
3343
import org.junit.Test;
3444

3545
import com.jayway.jsonpath.Configuration;
@@ -484,7 +494,7 @@ public void jsonObjectByObjectAndNames() {
484494
@Test
485495
public void jsonObjectByResourceBundle() {
486496
JSONObject jsonObject = new
487-
JSONObject("org.json.junit.StringsResourceBundle",
497+
JSONObject("org.json.junit.data.StringsResourceBundle",
488498
Locale.getDefault());
489499

490500
// validate JSON
@@ -2572,18 +2582,5 @@ public void toMap() {
25722582
// assert that the new map is mutable
25732583
assertTrue("Removing a key should succeed", map.remove("key3") != null);
25742584
assertTrue("Map should have 2 elements", map.size() == 2);
2575-
2576-
}
2577-
2578-
/**
2579-
* test class for verifying write errors.
2580-
* @author John Aylward
2581-
*
2582-
*/
2583-
private static class BrokenToString {
2584-
@Override
2585-
public String toString() {
2586-
throw new IllegalStateException("Something went horribly wrong!");
2587-
}
25882585
}
25892586
}
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
package org.json.junit.data;
2+
3+
/**
4+
* test class for verifying write errors.
5+
* @author John Aylward
6+
*
7+
*/
8+
public class BrokenToString {
9+
@Override
10+
public String toString() {
11+
throw new IllegalStateException("Something went horribly wrong!");
12+
}
13+
}

src/test/java/org/json/junit/Fraction.java renamed to src/test/java/org/json/junit/data/Fraction.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package org.json.junit;
1+
package org.json.junit.data;
22

33
import java.math.BigDecimal;
44
import java.math.BigInteger;

src/test/java/org/json/junit/MyBean.java renamed to src/test/java/org/json/junit/data/MyBean.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
package org.json.junit;
1+
package org.json.junit.data;
22

33
import java.io.*;
44

55
/**
66
* Used in testing when Bean behavior is needed
77
*/
8-
interface MyBean {
8+
public interface MyBean {
99
public Integer getIntKey();
1010
public Double getDoubleKey();
1111
public String getStringKey();
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
package org.json.junit;
1+
package org.json.junit.data;
22

33
import java.math.*;
44

55
/**
66
* Used in testing when a Bean containing big numbers is needed
77
*/
8-
interface MyBigNumberBean {
8+
public interface MyBigNumberBean {
99
public BigInteger getBigInteger();
1010
public BigDecimal getBigDecimal();
1111
}

src/test/java/org/json/junit/MyEnum.java renamed to src/test/java/org/json/junit/data/MyEnum.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package org.json.junit;
1+
package org.json.junit.data;
22

33
/**
44
* An enum with no methods or data

src/test/java/org/json/junit/MyEnumClass.java renamed to src/test/java/org/json/junit/data/MyEnumClass.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package org.json.junit;
1+
package org.json.junit.data;
22

33
/**
44
* this is simply a class that contains some enum instances

src/test/java/org/json/junit/MyEnumField.java renamed to src/test/java/org/json/junit/data/MyEnumField.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package org.json.junit;
1+
package org.json.junit.data;
22

33
/**
44
* An enum that contains getters and some internal fields

0 commit comments

Comments
 (0)