Skip to content

Conversation

@HichamELBSI
Copy link
Collaborator

What does it do?

Fixes the Datepicker unit tests.

Why is it needed?

Describe the issue you are solving.

How to test it?

Provide information about the environment and the path to verify the behaviour.

Related issue(s)/PR(s)

Let us know if this is related to any issue/pull request

@HichamELBSI HichamELBSI added pr: fix This PR is fixing a bug source: design-system relates to design-system package labels Oct 28, 2025
@changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2025

⚠️ No Changeset found

Latest commit: 93ce22f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 28, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
design-system Ready Ready Preview Comment Oct 28, 2025 9:01pm

@sonarqubecloud
Copy link

Copy link
Contributor

@Adzouz Adzouz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The results in the pipelines show that it was good before, why did you experience this issue? Was it locally?
Edit: I experience the same issue. I think that the formatting differs from an environment ecosystem to another... Maybe we could find a way to make it work for all of them? Or choose another locale to test on that would be identical everywhere.

@HichamELBSI
Copy link
Collaborator Author

The results in the pipelines show that it was good before, why did you experience this issue? Was it locally? Edit: I experience the same issue. I think that the formatting differs from an environment ecosystem to another... Maybe we could find a way to make it work for all of them? Or choose another locale to test on that would be identical everywhere.

Yes, you are totally right, thanks for the review. I wasn't sure about these changes we definitely need to test the dates differently to match all enrigonments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: fix This PR is fixing a bug source: design-system relates to design-system package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants