[AC] AC should hide once the whole word is typed and that word is the only suggested

[predragnikolic]

Noticed a bug with latest changes:

When, in Python, I'm typing False and getting an (only) suggestion with it, the suggestion popup doesn't disappear once I've typed whole word. It did before those changes.

Originally posted by @rchl in #866 (comment)

[rwols]

This looks like the complete opposite of #935 :)

[rchl]

Not really IMO as here you expect the popup to disappear because you've typed full and exact suggestion.

The other issue is about popup being hidden when match is only partial.

[predragnikolic]

Not really IMO as here you expect the popup to disappear because you've typed full and exact suggestion.

I would only add "... disappear because you've typed full and exact suggestion and there are no other completion items available."

[predragnikolic]

I think that sublime should handle this case.
I see nothing I should do about it in LSP.

[rwols]

I believe ST cannot hide the AC widget, because it’s a command completion. And selecting a command completion has the potential to replace “False” with “True”.

[rwols]

We could optimize for cases when:

• the server only sends insertText,
• the server has no completionResolve capability. There are no additionalTextEdits.

If these two conditions are true, then instead of a command completion we can use a snippet completion.

[rwols]

As it turns out we can always use a snippet_completion for pyls.

[rwols]

#992 also fixed this.

See the gif:

Because snippet completions are sufficient for pyls.