From e7407ed9fe27a821ebbe7065185ad7a9cc6502ef Mon Sep 17 00:00:00 2001 From: Geoffrey Sechter Date: Sat, 28 Feb 2026 18:38:17 -0700 Subject: [PATCH] fix(test): remove orphaned gock mock in TestUpdateRemoteConfig PR #4887 added an early return to UpdateDbNetworkRestrictionsConfig when NetworkRestrictions.Enabled is false, but didn't remove the corresponding gock mock from the "updates_all_configs" subtest. The mock was never consumed, causing gock.IsDone() to fail. --- pkg/config/updater_test.go | 5 ----- 1 file changed, 5 deletions(-) diff --git a/pkg/config/updater_test.go b/pkg/config/updater_test.go index c88e646c5..7dc70cf2b 100644 --- a/pkg/config/updater_test.go +++ b/pkg/config/updater_test.go @@ -331,11 +331,6 @@ func TestUpdateRemoteConfig(t *testing.T) { JSON(v1API.PostgresConfigResponse{ MaxConnections: cast.Ptr(cast.UintToInt(100)), }) - // Network config - gock.New(server). - Get("/v1/projects/test-project/network-restrictions"). - Reply(http.StatusOK). - JSON(v1API.V1GetNetworkRestrictionsResponse{}) // Auth config gock.New(server). Get("/v1/projects/test-project/config/auth").