-
Notifications
You must be signed in to change notification settings - Fork 8
Open
Description
In step 1.(3) of the protocol the payment hash is used directly as the message hash for a digital signature. This is not a secure way to create digital signatures, you need to hash the message (=payment hash) one more time to get to the message hash. If you do not do this, signatures can be forged by randomly creating the signature parameters first and deriving the message hash from them.
(You may get away with this here because then nobody knows the preimage, but I would still consider it bad practice!)
Metadata
Metadata
Assignees
Labels
No labels