Fix: Filter disabled models in smart and expert routing #10
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
这里简单添加 如果没有 |
Owner
直接 disabled 会导致权重计算异常，不过如果直接返回 null 倒也不会产生致命错误，超过三次重试会自动触发熔断器，对整体用户请求流程不会造成完全中断，可以使用 “占位模型" 角色？当命中该模型视为已经被触发熔断了自动选择下一个，这部分逻辑会比较难写 |
sxueck
force-pushed
the
main
branch
2 times, most recently
from
989aba2 to
cd6c776
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add enabled status check to model resolution in routing logic.
Why
Disabled models were being selected during routing, causing requests to be sent to models that administrators had explicitly disabled.
How
m.enabled === 1condition to model filtering inresolveSmartRouting()m.enabled === 1condition to model filtering inresolveExpertRouting()Impact