-
Notifications
You must be signed in to change notification settings - Fork 19
Description
While investigating issue #22, I've found some contradictions between version published to the Marketplace (1.0.127) and the sources in the repository.
The main difference seems to be that certain components are commented-out on GitHub:
IDLua/src/main/resources/META-INF/plugin.xml
Lines 88 to 96 in ffc0589
| <!-- <component>--> | |
| <!-- <implementation-class>com.sylvanaar.idea.Lua.sdk.KahluaSdk</implementation-class>--> | |
| <!-- </component>--> | |
| <!-- <component>--> | |
| <!-- <implementation-class>com.sylvanaar.idea.Lua.sdk.LuaJSdk</implementation-class>--> | |
| <!-- </component>--> | |
| <!--<component>--> | |
| <!--<implementation-class>com.sylvanaar.idea.Lua.LuaLoggerManager</implementation-class>--> | |
| <!--</component>--> |
The same components are enabled in the
plugin.xml of the published plugin version.
⚠Notably, disabling these components (i.e. using the version of plugin.xml from GitHub) lets the plugin to work in Rider. So maybe you really should publish a version without these components?
(namely, it's the com.sylvanaar.idea.Lua.LuaLoggerManager which causes a loading error in Rider; the reason for that is unknown yet, though is described in #27)
Another issue I've found is that build.gradle uses ideaVersion property:
Line 27 in ffc0589
| version ideaVersion |
This property is never defined in the repository, so one has to guess what version they should substitute to build the plugin (and I never was able to generate the same artifact as the one published on the Marketplace from the current sources).