Skip to content

Plugin sources don't correspond to the version that's published to the Marketplace #26

@ForNeVeR

Description

@ForNeVeR

While investigating issue #22, I've found some contradictions between version published to the Marketplace (1.0.127) and the sources in the repository.

The main difference seems to be that certain components are commented-out on GitHub:

<!-- <component>-->
<!-- <implementation-class>com.sylvanaar.idea.Lua.sdk.KahluaSdk</implementation-class>-->
<!-- </component>-->
<!-- <component>-->
<!-- <implementation-class>com.sylvanaar.idea.Lua.sdk.LuaJSdk</implementation-class>-->
<!-- </component>-->
<!--<component>-->
<!--<implementation-class>com.sylvanaar.idea.Lua.LuaLoggerManager</implementation-class>-->
<!--</component>-->

The same components are enabled in the plugin.xml of the published plugin version.

⚠Notably, disabling these components (i.e. using the version of plugin.xml from GitHub) lets the plugin to work in Rider. So maybe you really should publish a version without these components?

(namely, it's the com.sylvanaar.idea.Lua.LuaLoggerManager which causes a loading error in Rider; the reason for that is unknown yet, though is described in #27)

Another issue I've found is that build.gradle uses ideaVersion property:

version ideaVersion

This property is never defined in the repository, so one has to guess what version they should substitute to build the plugin (and I never was able to generate the same artifact as the one published on the Marketplace from the current sources).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions