Use ::class keyword when possible

fabpot · fabpot · commit 003b6e003801 · 2021-01-11T09:57:50.000+01:00
diff --git a/Client.php b/Client.php
@@ -117,7 +117,7 @@ public function getMaxRedirects()
      */
     public function insulate($insulated = true)
     {
-        if ($insulated && !class_exists('Symfony\\Component\\Process\\Process')) {
+        if ($insulated && !class_exists(\Symfony\Component\Process\Process::class)) {
             throw new \LogicException('Unable to isolate requests as the Symfony Process Component is not installed.');
         }
 
@@ -527,7 +527,7 @@ protected function filterResponse($response)
      */
     protected function createCrawlerFromContent($uri, $content, $type)
     {
-        if (!class_exists('Symfony\Component\DomCrawler\Crawler')) {
+        if (!class_exists(Crawler::class)) {
             return null;
         }
 
diff --git a/Tests/AbstractBrowserTest.php b/Tests/AbstractBrowserTest.php
@@ -89,7 +89,7 @@ public function testGetResponse()
         $client->request('GET', 'http://example.com/');
 
         $this->assertSame('foo', $client->getResponse()->getContent(), '->getCrawler() returns the Response of the last request');
-        $this->assertInstanceOf('Symfony\Component\BrowserKit\Response', $client->getResponse(), '->getCrawler() returns the Response of the last request');
+        $this->assertInstanceOf(Response::class, $client->getResponse(), '->getCrawler() returns the Response of the last request');
     }
 
     /**
@@ -300,7 +300,7 @@ public function testClickLinkNotFound()
             $client->clickLink('foo');
             $this->fail('->clickLink() throws a \InvalidArgumentException if the link could not be found');
         } catch (\Exception $e) {
-            $this->assertInstanceOf('InvalidArgumentException', $e, '->clickLink() throws a \InvalidArgumentException if the link could not be found');
+            $this->assertInstanceOf(\InvalidArgumentException::class, $e, '->clickLink() throws a \InvalidArgumentException if the link could not be found');
         }
     }
 
@@ -359,7 +359,7 @@ public function testSubmitFormNotFound()
             ], 'POST');
             $this->fail('->submitForm() throws a \InvalidArgumentException if the form could not be found');
         } catch (\Exception $e) {
-            $this->assertInstanceOf('InvalidArgumentException', $e, '->submitForm() throws a \InvalidArgumentException if the form could not be found');
+            $this->assertInstanceOf(\InvalidArgumentException::class, $e, '->submitForm() throws a \InvalidArgumentException if the form could not be found');
         }
     }
 
@@ -410,7 +410,7 @@ public function testFollowRedirect()
             $client->followRedirect();
             $this->fail('->followRedirect() throws a \LogicException if the request was not redirected');
         } catch (\Exception $e) {
-            $this->assertInstanceOf('LogicException', $e, '->followRedirect() throws a \LogicException if the request was not redirected');
+            $this->assertInstanceOf(\LogicException::class, $e, '->followRedirect() throws a \LogicException if the request was not redirected');
         }
 
         $client->setNextResponse(new Response('', 302, ['Location' => 'http://www.example.com/redirected']));
@@ -440,7 +440,7 @@ public function testFollowRedirect()
             $client->followRedirect();
             $this->fail('->followRedirect() throws a \LogicException if the request did not respond with 30x HTTP Code');
         } catch (\Exception $e) {
-            $this->assertInstanceOf('LogicException', $e, '->followRedirect() throws a \LogicException if the request did not respond with 30x HTTP Code');
+            $this->assertInstanceOf(\LogicException::class, $e, '->followRedirect() throws a \LogicException if the request did not respond with 30x HTTP Code');
         }
     }
 
@@ -470,7 +470,7 @@ public function testFollowRedirectWithMaxRedirects()
             $client->followRedirect();
             $this->fail('->followRedirect() throws a \LogicException if the request was redirected and limit of redirections was reached');
         } catch (\Exception $e) {
-            $this->assertInstanceOf('LogicException', $e, '->followRedirect() throws a \LogicException if the request was redirected and limit of redirections was reached');
+            $this->assertInstanceOf(\LogicException::class, $e, '->followRedirect() throws a \LogicException if the request was redirected and limit of redirections was reached');
         }
 
         $client->setNextResponse(new Response('', 302, ['Location' => 'http://www.example.com/redirected']));
@@ -753,7 +753,7 @@ public function testInsulatedRequests()
             $client->request('GET', 'http://www.example.com/foo/foobar');
             $this->fail('->request() throws a \RuntimeException if the script has an error');
         } catch (\Exception $e) {
-            $this->assertInstanceOf('RuntimeException', $e, '->request() throws a \RuntimeException if the script has an error');
+            $this->assertInstanceOf(\RuntimeException::class, $e, '->request() throws a \RuntimeException if the script has an error');
         }
     }
 
@@ -841,7 +841,7 @@ public function testInternalRequest()
             'NEW_SERVER_KEY' => 'new-server-key-value',
         ]);
 
-        $this->assertInstanceOf('Symfony\Component\BrowserKit\Request', $client->getInternalRequest());
+        $this->assertInstanceOf(\Symfony\Component\BrowserKit\Request::class, $client->getInternalRequest());
     }
 
     /**
diff --git a/Tests/CookieJarTest.php b/Tests/CookieJarTest.php
@@ -77,8 +77,8 @@ public function testUpdateFromSetCookie()
         $cookieJar->set(new Cookie('bar', 'bar'));
         $cookieJar->updateFromSetCookie($setCookies);
 
-        $this->assertInstanceOf('Symfony\Component\BrowserKit\Cookie', $cookieJar->get('foo'));
-        $this->assertInstanceOf('Symfony\Component\BrowserKit\Cookie', $cookieJar->get('bar'));
+        $this->assertInstanceOf(Cookie::class, $cookieJar->get('foo'));
+        $this->assertInstanceOf(Cookie::class, $cookieJar->get('bar'));
         $this->assertEquals('foo', $cookieJar->get('foo')->getValue(), '->updateFromSetCookie() updates cookies from a Set-Cookie header');
         $this->assertEquals('bar', $cookieJar->get('bar')->getValue(), '->updateFromSetCookie() keeps existing cookies');
     }
@@ -103,9 +103,9 @@ public function testUpdateFromSetCookieWithMultipleCookies()
         $barCookie = $cookieJar->get('bar', '/', '.blog.symfony.com');
         $phpCookie = $cookieJar->get('PHPSESSID');
 
-        $this->assertInstanceOf('Symfony\Component\BrowserKit\Cookie', $fooCookie);
-        $this->assertInstanceOf('Symfony\Component\BrowserKit\Cookie', $barCookie);
-        $this->assertInstanceOf('Symfony\Component\BrowserKit\Cookie', $phpCookie);
+        $this->assertInstanceOf(Cookie::class, $fooCookie);
+        $this->assertInstanceOf(Cookie::class, $barCookie);
+        $this->assertInstanceOf(Cookie::class, $phpCookie);
         $this->assertEquals('foo', $fooCookie->getValue());
         $this->assertEquals('bar', $barCookie->getValue());
         $this->assertEquals('id', $phpCookie->getValue());
diff --git a/Tests/CookieTest.php b/Tests/CookieTest.php
@@ -103,7 +103,7 @@ public function testFromStringWithUrl()
 
     public function testFromStringThrowsAnExceptionIfCookieIsNotValid()
     {
-        $this->expectException('InvalidArgumentException');
+        $this->expectException(\InvalidArgumentException::class);
         Cookie::fromString('foo');
     }
 
@@ -116,7 +116,7 @@ public function testFromStringIgnoresInvalidExpiresDate()
 
     public function testFromStringThrowsAnExceptionIfUrlIsNotValid()
     {
-        $this->expectException('InvalidArgumentException');
+        $this->expectException(\InvalidArgumentException::class);
         Cookie::fromString('foo=bar', 'foobar');
     }
 
@@ -199,7 +199,7 @@ public function testIsExpired()
 
     public function testConstructException()
     {
-        $this->expectException('UnexpectedValueException');
+        $this->expectException(\UnexpectedValueException::class);
         $this->expectExceptionMessage('The cookie expiration time "string" is not valid.');
         new Cookie('foo', 'bar', 'string');
     }
diff --git a/Tests/HistoryTest.php b/Tests/HistoryTest.php
@@ -55,7 +55,7 @@ public function testCurrent()
             $history->current();
             $this->fail('->current() throws a \LogicException if the history is empty');
         } catch (\Exception $e) {
-            $this->assertInstanceOf('LogicException', $e, '->current() throws a \LogicException if the history is empty');
+            $this->assertInstanceOf(\LogicException::class, $e, '->current() throws a \LogicException if the history is empty');
         }
 
         $history->add(new Request('http://www.example.com/', 'get'));
@@ -72,7 +72,7 @@ public function testBack()
             $history->back();
             $this->fail('->back() throws a \LogicException if the history is already on the first page');
         } catch (\Exception $e) {
-            $this->assertInstanceOf('LogicException', $e, '->current() throws a \LogicException if the history is already on the first page');
+            $this->assertInstanceOf(\LogicException::class, $e, '->current() throws a \LogicException if the history is already on the first page');
         }
 
         $history->add(new Request('http://www.example1.com/', 'get'));
@@ -91,7 +91,7 @@ public function testForward()
             $history->forward();
             $this->fail('->forward() throws a \LogicException if the history is already on the last page');
         } catch (\Exception $e) {
-            $this->assertInstanceOf('LogicException', $e, '->forward() throws a \LogicException if the history is already on the last page');
+            $this->assertInstanceOf(\LogicException::class, $e, '->forward() throws a \LogicException if the history is already on the last page');
         }
 
         $history->back();
diff --git a/Tests/TestClient.php b/Tests/TestClient.php
@@ -43,7 +43,7 @@ protected function doRequest($request): Response
 
     protected function getScript($request)
     {
-        $r = new \ReflectionClass('Symfony\Component\BrowserKit\Response');
+        $r = new \ReflectionClass(Response::class);
         $path = $r->getFileName();
 
         return <<<EOF
diff --git a/Tests/TestHttpClient.php b/Tests/TestHttpClient.php
@@ -66,7 +66,7 @@ protected function doRequest($request): Response
 
     protected function getScript($request)
     {
-        $r = new \ReflectionClass('Symfony\Component\BrowserKit\Response');
+        $r = new \ReflectionClass(Response::class);
         $path = $r->getFileName();
 
         return <<<EOF

Original file line number	Diff line number	Diff line change
`@@ -117,7 +117,7 @@ public function getMaxRedirects()`
`117`	`117`	`*/`
`118`	`118`	`public function insulate($insulated = true)`
`119`	`119`	`{`
`120`		`- if ($insulated && !class_exists('Symfony\\Component\\Process\\Process')) {`
	`120`	`+ if ($insulated && !class_exists(\Symfony\Component\Process\Process::class)) {`
`121`	`121`	`throw new \LogicException('Unable to isolate requests as the Symfony Process Component is not installed.');`
`122`	`122`	`}`
`123`	`123`
`@@ -527,7 +527,7 @@ protected function filterResponse($response)`
`527`	`527`	`*/`
`528`	`528`	`protected function createCrawlerFromContent($uri, $content, $type)`
`529`	`529`	`{`
`530`		`- if (!class_exists('Symfony\Component\DomCrawler\Crawler')) {`
	`530`	`+ if (!class_exists(Crawler::class)) {`
`531`	`531`	`return null;`
`532`	`532`	`}`
`533`	`533`
Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,7 @@ public function testGetResponse()`
`89`	`89`	`$client->request('GET', 'http://example.com/');`
`90`	`90`
`91`	`91`	`$this->assertSame('foo', $client->getResponse()->getContent(), '->getCrawler() returns the Response of the last request');`
`92`		`- $this->assertInstanceOf('Symfony\Component\BrowserKit\Response', $client->getResponse(), '->getCrawler() returns the Response of the last request');`
	`92`	`+ $this->assertInstanceOf(Response::class, $client->getResponse(), '->getCrawler() returns the Response of the last request');`
`93`	`93`	`}`
`94`	`94`
`95`	`95`	`/**`
`@@ -300,7 +300,7 @@ public function testClickLinkNotFound()`
`300`	`300`	`$client->clickLink('foo');`
`301`	`301`	`$this->fail('->clickLink() throws a \InvalidArgumentException if the link could not be found');`
`302`	`302`	`} catch (\Exception $e) {`
`303`		`- $this->assertInstanceOf('InvalidArgumentException', $e, '->clickLink() throws a \InvalidArgumentException if the link could not be found');`
	`303`	`+ $this->assertInstanceOf(\InvalidArgumentException::class, $e, '->clickLink() throws a \InvalidArgumentException if the link could not be found');`
`304`	`304`	`}`
`305`	`305`	`}`
`306`	`306`
`@@ -359,7 +359,7 @@ public function testSubmitFormNotFound()`
`359`	`359`	`], 'POST');`
`360`	`360`	`$this->fail('->submitForm() throws a \InvalidArgumentException if the form could not be found');`
`361`	`361`	`} catch (\Exception $e) {`
`362`		`- $this->assertInstanceOf('InvalidArgumentException', $e, '->submitForm() throws a \InvalidArgumentException if the form could not be found');`
	`362`	`+ $this->assertInstanceOf(\InvalidArgumentException::class, $e, '->submitForm() throws a \InvalidArgumentException if the form could not be found');`
`363`	`363`	`}`
`364`	`364`	`}`
`365`	`365`
`@@ -410,7 +410,7 @@ public function testFollowRedirect()`
`410`	`410`	`$client->followRedirect();`
`411`	`411`	`$this->fail('->followRedirect() throws a \LogicException if the request was not redirected');`
`412`	`412`	`} catch (\Exception $e) {`
`413`		`- $this->assertInstanceOf('LogicException', $e, '->followRedirect() throws a \LogicException if the request was not redirected');`
	`413`	`+ $this->assertInstanceOf(\LogicException::class, $e, '->followRedirect() throws a \LogicException if the request was not redirected');`
`414`	`414`	`}`
`415`	`415`
`416`	`416`	`$client->setNextResponse(new Response('', 302, ['Location' => 'http://www.example.com/redirected']));`
`@@ -440,7 +440,7 @@ public function testFollowRedirect()`
`440`	`440`	`$client->followRedirect();`
`441`	`441`	`$this->fail('->followRedirect() throws a \LogicException if the request did not respond with 30x HTTP Code');`
`442`	`442`	`} catch (\Exception $e) {`
`443`		`- $this->assertInstanceOf('LogicException', $e, '->followRedirect() throws a \LogicException if the request did not respond with 30x HTTP Code');`
	`443`	`+ $this->assertInstanceOf(\LogicException::class, $e, '->followRedirect() throws a \LogicException if the request did not respond with 30x HTTP Code');`
`444`	`444`	`}`
`445`	`445`	`}`
`446`	`446`
`@@ -470,7 +470,7 @@ public function testFollowRedirectWithMaxRedirects()`
`470`	`470`	`$client->followRedirect();`
`471`	`471`	`$this->fail('->followRedirect() throws a \LogicException if the request was redirected and limit of redirections was reached');`
`472`	`472`	`} catch (\Exception $e) {`
`473`		`- $this->assertInstanceOf('LogicException', $e, '->followRedirect() throws a \LogicException if the request was redirected and limit of redirections was reached');`
	`473`	`+ $this->assertInstanceOf(\LogicException::class, $e, '->followRedirect() throws a \LogicException if the request was redirected and limit of redirections was reached');`
`474`	`474`	`}`
`475`	`475`
`476`	`476`	`$client->setNextResponse(new Response('', 302, ['Location' => 'http://www.example.com/redirected']));`
`@@ -753,7 +753,7 @@ public function testInsulatedRequests()`
`753`	`753`	`$client->request('GET', 'http://www.example.com/foo/foobar');`
`754`	`754`	`$this->fail('->request() throws a \RuntimeException if the script has an error');`
`755`	`755`	`} catch (\Exception $e) {`
`756`		`- $this->assertInstanceOf('RuntimeException', $e, '->request() throws a \RuntimeException if the script has an error');`
	`756`	`+ $this->assertInstanceOf(\RuntimeException::class, $e, '->request() throws a \RuntimeException if the script has an error');`
`757`	`757`	`}`
`758`	`758`	`}`
`759`	`759`
`@@ -841,7 +841,7 @@ public function testInternalRequest()`
`841`	`841`	`'NEW_SERVER_KEY' => 'new-server-key-value',`
`842`	`842`	`]);`
`843`	`843`
`844`		`- $this->assertInstanceOf('Symfony\Component\BrowserKit\Request', $client->getInternalRequest());`
	`844`	`+ $this->assertInstanceOf(\Symfony\Component\BrowserKit\Request::class, $client->getInternalRequest());`
`845`	`845`	`}`
`846`	`846`
`847`	`847`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,7 @@ public function testFromStringWithUrl()`
`103`	`103`
`104`	`104`	`public function testFromStringThrowsAnExceptionIfCookieIsNotValid()`
`105`	`105`	`{`
`106`		`- $this->expectException('InvalidArgumentException');`
	`106`	`+ $this->expectException(\InvalidArgumentException::class);`
`107`	`107`	`Cookie::fromString('foo');`
`108`	`108`	`}`
`109`	`109`
`@@ -116,7 +116,7 @@ public function testFromStringIgnoresInvalidExpiresDate()`
`116`	`116`
`117`	`117`	`public function testFromStringThrowsAnExceptionIfUrlIsNotValid()`
`118`	`118`	`{`
`119`		`- $this->expectException('InvalidArgumentException');`
	`119`	`+ $this->expectException(\InvalidArgumentException::class);`
`120`	`120`	`Cookie::fromString('foo=bar', 'foobar');`
`121`	`121`	`}`
`122`	`122`
`@@ -199,7 +199,7 @@ public function testIsExpired()`
`199`	`199`
`200`	`200`	`public function testConstructException()`
`201`	`201`	`{`
`202`		`- $this->expectException('UnexpectedValueException');`
	`202`	`+ $this->expectException(\UnexpectedValueException::class);`
`203`	`203`	`$this->expectExceptionMessage('The cookie expiration time "string" is not valid.');`
`204`	`204`	`new Cookie('foo', 'bar', 'string');`
`205`	`205`	`}`
Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ protected function doRequest($request): Response`
`43`	`43`
`44`	`44`	`protected function getScript($request)`
`45`	`45`	`{`
`46`		`- $r = new \ReflectionClass('Symfony\Component\BrowserKit\Response');`
	`46`	`+ $r = new \ReflectionClass(Response::class);`
`47`	`47`	`$path = $r->getFileName();`
`48`	`48`
`49`	`49`	`return <<<EOF`
Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ protected function doRequest($request): Response`
`66`	`66`
`67`	`67`	`protected function getScript($request)`
`68`	`68`	`{`
`69`		`- $r = new \ReflectionClass('Symfony\Component\BrowserKit\Response');`
	`69`	`+ $r = new \ReflectionClass(Response::class);`
`70`	`70`	`$path = $r->getFileName();`
`71`	`71`
`72`	`72`	`return <<<EOF`