Leverage non-capturing catches

fancyweb · fancyweb · commit 115bad034900 · 2022-04-01T09:15:35.000+02:00
diff --git a/CookieJar.php b/CookieJar.php
@@ -122,7 +122,7 @@ public function updateFromSetCookie(array $setCookies, string $uri = null)
         foreach ($cookies as $cookie) {
             try {
                 $this->set(Cookie::fromString($cookie, $uri));
-            } catch (\InvalidArgumentException $e) {
+            } catch (\InvalidArgumentException) {
                 // invalid cookies are just ignored
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -122,7 +122,7 @@ public function updateFromSetCookie(array $setCookies, string $uri = null)`
`122`	`122`	`foreach ($cookies as $cookie) {`
`123`	`123`	`try {`
`124`	`124`	`$this->set(Cookie::fromString($cookie, $uri));`
`125`		`- } catch (\InvalidArgumentException $e) {`
	`125`	`+ } catch (\InvalidArgumentException) {`
`126`	`126`	`// invalid cookies are just ignored`
`127`	`127`	`}`
`128`	`128`	`}`