Skip to content

Commit 94be3fc

Browse files
committed
minor #47390 [CS] Remove @inheritdoc PHPDoc (lyrixx)
This PR was merged into the 6.2 branch. Discussion ---------- [CS] Remove `@inheritdoc` PHPDoc | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | --- It looks like this PHP Doc is useless. IDEs are able to inherit the doc (at least VS Code and PHP Storm). And tools like PHP Stan are able to too https://phpstan.org/r/74a2c008-ff2b-42c0-8edf-8da87c1a7b5f I could have open an RFC before doing the PR, but it was easy :) So let's discuss here Commits ------- 015d5015e3 [CS] Remove `@inheritdoc` PHPDoc
2 parents d224e85 + eba7cd3 commit 94be3fc

File tree

2 files changed

+0
-14
lines changed

2 files changed

+0
-14
lines changed

Test/Constraint/BrowserCookieValueSame.php

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,6 @@ public function __construct(string $name, string $value, bool $raw = false, stri
3131
$this->raw = $raw;
3232
}
3333

34-
/**
35-
* {@inheritdoc}
36-
*/
3734
public function toString(): string
3835
{
3936
$str = sprintf('has cookie "%s"', $this->name);
@@ -50,8 +47,6 @@ public function toString(): string
5047

5148
/**
5249
* @param AbstractBrowser $browser
53-
*
54-
* {@inheritdoc}
5550
*/
5651
protected function matches($browser): bool
5752
{
@@ -65,8 +60,6 @@ protected function matches($browser): bool
6560

6661
/**
6762
* @param AbstractBrowser $browser
68-
*
69-
* {@inheritdoc}
7063
*/
7164
protected function failureDescription($browser): string
7265
{

Test/Constraint/BrowserHasCookie.php

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,6 @@ public function __construct(string $name, string $path = '/', string $domain = n
2727
$this->domain = $domain;
2828
}
2929

30-
/**
31-
* {@inheritdoc}
32-
*/
3330
public function toString(): string
3431
{
3532
$str = sprintf('has cookie "%s"', $this->name);
@@ -45,8 +42,6 @@ public function toString(): string
4542

4643
/**
4744
* @param AbstractBrowser $browser
48-
*
49-
* {@inheritdoc}
5045
*/
5146
protected function matches($browser): bool
5247
{
@@ -55,8 +50,6 @@ protected function matches($browser): bool
5550

5651
/**
5752
* @param AbstractBrowser $browser
58-
*
59-
* {@inheritdoc}
6053
*/
6154
protected function failureDescription($browser): string
6255
{

0 commit comments

Comments
 (0)