Use typed properties in tests as much as possible

nicolas-grekas · nicolas-grekas · commit db56b5eb3a68 · 2023-07-25T10:53:33.000+02:00
diff --git a/Tests/TestClient.php b/Tests/TestClient.php
@@ -16,8 +16,8 @@
 
 class TestClient extends AbstractBrowser
 {
-    protected $nextResponse;
-    protected $nextScript;
+    protected ?Response $nextResponse = null;
+    protected string $nextScript;
 
     public function setNextResponse(Response $response)
     {
diff --git a/Tests/TestHttpClient.php b/Tests/TestHttpClient.php
@@ -20,8 +20,8 @@
 
 class TestHttpClient extends HttpBrowser
 {
-    protected $nextResponse;
-    protected $nextScript;
+    protected ?Response $nextResponse = null;
+    protected string $nextScript;
 
     public function __construct(array $server = [], History $history = null, CookieJar $cookieJar = null)
     {

Original file line number	Diff line number	Diff line change
`@@ -16,8 +16,8 @@`
`16`	`16`
`17`	`17`	`class TestClient extends AbstractBrowser`
`18`	`18`	`{`
`19`		`- protected $nextResponse;`
`20`		`- protected $nextScript;`
	`19`	`+ protected ?Response $nextResponse = null;`
	`20`	`+ protected string $nextScript;`
`21`	`21`
`22`	`22`	`public function setNextResponse(Response $response)`
`23`	`23`	`{`
Original file line number	Diff line number	Diff line change
`@@ -20,8 +20,8 @@`
`20`	`20`
`21`	`21`	`class TestHttpClient extends HttpBrowser`
`22`	`22`	`{`
`23`		`- protected $nextResponse;`
`24`		`- protected $nextScript;`
	`23`	`+ protected ?Response $nextResponse = null;`
	`24`	`+ protected string $nextScript;`
`25`	`25`
`26`	`26`	`public function __construct(array $server = [], History $history = null, CookieJar $cookieJar = null)`
`27`	`27`	`{`