[BrowserKit] Add types to private properties

Signed-off-by: Alexander M. Turek <me@derrabus.de>

Author: derrabus

AbstractBrowser.php

@@ -42,10 +42,10 @@ abstract class AbstractBrowser
     protected $followRedirects = true;
     protected $followMetaRefresh = false;
 
-    private $maxRedirects = -1;
-    private $redirectCount = 0;
-    private $redirects = [];
-    private $isMainRequest = true;
+    private int $maxRedirects = -1;
+    private int $redirectCount = 0;
+    private array $redirects = [];
+    private bool $isMainRequest = true;
 
     /**
      * @param array $server The server parameters (equivalent of $_SERVER)

Cookie.php

@@ -40,7 +40,7 @@ class Cookie
     protected $secure;
     protected $httponly;
     protected $rawValue;
-    private $samesite;
+    private ?string $samesite;
 
     /**
      * Sets a cookie.

HttpBrowser.php

@@ -26,7 +26,7 @@
  */
 class HttpBrowser extends AbstractBrowser
 {
-    private $client;
+    private HttpClientInterface $client;
 
     public function __construct(HttpClientInterface $client = null, History $history = null, CookieJar $cookieJar = null)
     {

Response.php

@@ -16,9 +16,9 @@
  */
 final class Response
 {
-    private $content;
-    private $status;
-    private $headers;
+    private string $content;
+    private int $status;
+    private array $headers;
 
     /**
      * The headers array is a set of key/value pairs. If a header is present multiple times

Test/Constraint/BrowserCookieValueSame.php

@@ -16,11 +16,11 @@
 
 final class BrowserCookieValueSame extends Constraint
 {
-    private $name;
-    private $value;
-    private $raw;
-    private $path;
-    private $domain;
+    private string $name;
+    private string $value;
+    private bool $raw;
+    private string $path;
+    private ?string $domain;
 
     public function __construct(string $name, string $value, bool $raw = false, string $path = '/', string $domain = null)
     {

Test/Constraint/BrowserHasCookie.php

@@ -16,9 +16,9 @@
 
 final class BrowserHasCookie extends Constraint
 {
-    private $name;
-    private $path;
-    private $domain;
+    private string $name;
+    private string $path;
+    private ?string $domain;
 
     public function __construct(string $name, string $path = '/', string $domain = null)
     {