Add types to constructors and private/final/internal methods (Batch I)

derrabus · fabpot · commit eeade4030711 · 2019-09-27T07:43:04.000+02:00
diff --git a/Client.php b/Client.php
@@ -710,7 +710,7 @@ protected function requestFromRequest(Request $request, $changeHistory = true)
         return $this->request($request->getMethod(), $request->getUri(), $request->getParameters(), $request->getFiles(), $request->getServer(), $request->getContent(), $changeHistory);
     }
 
-    private function updateServerFromUri(array $server, string $uri)
+    private function updateServerFromUri(array $server, string $uri): array
     {
         $server['HTTP_HOST'] = $this->extractHost($uri);
         $scheme = parse_url($uri, PHP_URL_SCHEME);
@@ -720,7 +720,7 @@ private function updateServerFromUri(array $server, string $uri)
         return $server;
     }
 
-    private function extractHost(string $uri)
+    private function extractHost(string $uri): ?string
     {
         $host = parse_url($uri, PHP_URL_HOST);
 

Original file line number	Diff line number	Diff line change
`@@ -710,7 +710,7 @@ protected function requestFromRequest(Request $request, $changeHistory = true)`
`710`	`710`	`return $this->request($request->getMethod(), $request->getUri(), $request->getParameters(), $request->getFiles(), $request->getServer(), $request->getContent(), $changeHistory);`
`711`	`711`	`}`
`712`	`712`
`713`		`- private function updateServerFromUri(array $server, string $uri)`
	`713`	`+ private function updateServerFromUri(array $server, string $uri): array`
`714`	`714`	`{`
`715`	`715`	`$server['HTTP_HOST'] = $this->extractHost($uri);`
`716`	`716`	`$scheme = parse_url($uri, PHP_URL_SCHEME);`
`@@ -720,7 +720,7 @@ private function updateServerFromUri(array $server, string $uri)`
`720`	`720`	`return $server;`
`721`	`721`	`}`
`722`	`722`
`723`		`- private function extractHost(string $uri)`
	`723`	`+ private function extractHost(string $uri): ?string`
`724`	`724`	`{`
`725`	`725`	`$host = parse_url($uri, PHP_URL_HOST);`
`726`	`726`