Skip to content

Commit 777459b

Browse files
committed
Fix unit test for test_no_mdd_failures
1 parent c6214f3 commit 777459b

File tree

3 files changed

+10
-3
lines changed

3 files changed

+10
-3
lines changed

vali_objects/utils/live_price_fetcher.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,6 @@ def get_latest_price(self, trade_pair: TradePair, time_ms=None) -> Tuple[float,
8888
Gets the latest price for a single trade pair by utilizing WebSocket and possibly REST data sources.
8989
Tries to get the price as close to time_ms as possible.
9090
"""
91-
# if not time_ms:
92-
# time_ms = TimeUtil.now_in_millis()
9391
price_sources = self.get_sorted_price_sources_for_trade_pair(trade_pair, time_ms)
9492
winning_event = PriceSource.get_winning_event(price_sources, time_ms)
9593
return winning_event.parse_best_best_price_legacy(time_ms), price_sources

vali_objects/vali_dataclasses/price_source.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import bittensor as bt
55
from typing import Optional
66
from pydantic import BaseModel
7+
from time_util.time_util import TimeUtil
78

89
from vali_objects.enums.order_type_enum import OrderType
910

@@ -55,14 +56,18 @@ def end_ms(self):
5556
def get_start_time_ms(self):
5657
return self.start_ms
5758

58-
def time_delta_from_now_ms(self, now_ms: int) -> int:
59+
def time_delta_from_now_ms(self, now_ms:int = None) -> int:
60+
if not now_ms:
61+
now_ms = TimeUtil.now_in_millis()
5962
if self.websocket:
6063
return abs(now_ms - self.start_ms)
6164
else:
6265
return min(abs(now_ms - self.start_ms),
6366
abs(now_ms - self.end_ms))
6467

6568
def parse_best_best_price_legacy(self, now_ms: int):
69+
if not now_ms:
70+
now_ms = TimeUtil.now_in_millis()
6671
if self.websocket:
6772
return self.open
6873
else:

vali_objects/vali_dataclasses/recent_event_tracker.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,11 @@ def get_closest_event(self, timestamp_ms):
8080
#print(f"Looking for event at {TimeUtil.millis_to_formatted_date_str(timestamp_ms)}")
8181
if self.count_events() == 0:
8282
return None
83+
8384
# Find the event closest to the given timestamp
85+
if not timestamp_ms:
86+
timestamp_ms = TimeUtil.now_in_millis()
87+
8488
idx = self.events.bisect_left((timestamp_ms,))
8589
if idx == 0:
8690
return self.events[0][1]

0 commit comments

Comments
 (0)