Improve download function

- Allow to specify used filename
- Output all settings as a comment on top of gcode
- Unify download buttons

Author: ayufan

calibration.html

@@ -255,10 +255,8 @@ <h6 id="fl" >First layer gcode generator</h6>
         <!-- firstlayerForm -->
         <form name="firstlayerForm" id="firstlayerForm" onsubmit="return false;">
             <script>
-            createForm("firstlayer");    
+                createForm("firstlayer");
             </script>
-            <p><input type="button" onclick="processGcode(form)" value="Download Gcode"></p>
-            <p><input type="button" onclick="resetFormToDefaults(form)" value="Reset parameters"> <input type="button" onclick="outputSettings(form)" value="Output Settings Summary"></p>
         </form>
         <h2>Interpreting Results:</h2>
         <p>Please use the following video as a guide to this test:</p>
@@ -285,10 +283,8 @@ <h6 id="bl">Baseline test print generator</h6>
         <!-- baselineForm -->
         <form name="baselineForm" id="baselineForm" onsubmit="return false;">
             <script>
-                createForm("baseline");    
+                createForm("baseline");
             </script>
-            <p><input type="button" onclick="processGcode(form)" value="Download Gcode"></p>
-            <p><input type="button" onclick="resetFormToDefaults(form)" value="Reset parameters"> <input type="button" onclick="outputSettings(form)" value="Output Settings Summary"></p>
         </form>
         <h2>Interpreting Results:</h2>
         <p>Please use the following video as a guide to this test:</p>
@@ -690,8 +686,6 @@ <h6 id="ret">Retraction tuning tower generator</h6>
             <script>
                 createForm("retraction");
             </script>
-            <p><input type="button" onclick="processGcode(form)" value="Download Gcode"></p>
-            <p><input type="button" onclick="resetFormToDefaults(form)" value="Reset parameters"> <input type="button" onclick="outputSettings(form)" value="Output Settings Summary"></p>
         </form>
         <h2>Interpreting Results:</h2>
         <p>Please use the following video as a guide to this test:</p>
@@ -748,8 +742,6 @@ <h6 id="tmp">Temperature tuning tower generator</h6>
             <script>
                 createForm("temperature");
             </script>
-            <p><input type="button" onclick="processGcode(form)" value="Download Gcode"></p>
-            <p><input type="button" onclick="resetFormToDefaults(form)" value="Reset parameters"> <input type="button" onclick="outputSettings(form)" value="Output Settings Summary"></p>
         </form>
         <h2>Interpreting Results:</h2>
         <p>Please use the following video as a guide to this test:</p>
@@ -855,8 +847,6 @@ <h6 id="acc">Acceleration & jerk/junction deviation tuning tower generator</h6>
             <script>
                 createForm("acceleration");
             </script>
-            <p><input type="button" onclick="processGcode(form)" value="Download Gcode"></p>
-            <p><input type="button" onclick="resetFormToDefaults(form)" value="Reset parameters"> <input type="button" onclick="outputSettings(form)" value="Output Settings Summary"></p>
         </form>
         <h2>Interpreting Results:</h2>
         <p>Please use the following video as a guide to this test:</p>

js/commongcode.js

@@ -1,6 +1,4 @@
-var commonStart = `; G-Code originally generated by Simplify3D(R) Version 4.1.2
-; This calibration test gcode modified by the Teaching Tech Calibration website: https://teachingtechyt.github.io/calibration.html
-;M80 ; power supply on
+var commonStart = `;M80 ; power supply on
 G90
 M82
 M106 S0

js/createform.js

@@ -326,6 +326,13 @@ var endGcode = /*html*/ `<h4>Additional end gcode</h4>
 
 var preview = /*html*/ `<p>It is advised to preview the generated gcode through your slicer or <a href="http://gcode.ws/" target="_blank">Gcode.ws</a> before printing.`;
 
+var downloadGcodeHtml = /*html*/ `<h4>Download</h4>
+<p><label>Filename: <input type="text" name="{formName}_filename" value="{formName}.gcode"></label></p>
+<p><input type="button" onclick="downloadGcode(form, form['{formName}_filename'].value)" value="Download Gcode"></p>
+<p><input type="button" onclick="resetFormToDefaults(form)" value="Reset parameters">
+   <input type="button" onclick="downloadSettings(form, form['{formName}_filename'].value)" value="Output Settings Summary"></p>
+`;
+
 function createForm(n){
     document.write('<input type="hidden" name="description" value="'+n+'">')
     document.write(nozzleLayer);
@@ -357,4 +364,5 @@ function createForm(n){
     }
     document.write(endGcode);
     document.write(preview);
-}      
+    document.write(downloadGcodeHtml.replaceAll('{formName}', n));
+}

js/gcodeprocessing.js

@@ -112,7 +112,6 @@ function updateFeeds(feedrate) {
 
 function processGcode(formName) {
     var name = formName.name;
-    var description = formName.description.value;
     var nozzleLayer = formName.nozzleLayer.value;
     var bedTemp = formName.bedtemp.value;
     var centre = formName.centre.checked;
@@ -544,37 +543,14 @@ function processGcode(formName) {
     if(formName.deltaHome.checked == true) {
         gcode = gcode.replace(/G28 X0 ; home X axis/, "G28 ; home all on delta");
     }
-    
-    // process finished gcode file
-    downloadFile(description+'.gcode', gcode);
+
+    return gcode;
 }
 
 function outputSettings(formName) {
-    var fileName;
-    var string = "Settings for ";
-    switch(formName.name) {
-        case "firstlayerForm":
-            string += "first layer"
-            fileName = "firstlayersettings.txt";
-            break;
-        case "baselineForm":
-            string += "baseline print"
-            fileName = "baselinesettings.txt";
-            break;
-        case "retractionForm":
-            string += "retraction tuning"
-            fileName = "retractionsettings.txt";
-            break;
-        case "temperatureForm":
-            string += "temperature tuning"
-            fileName = "temperaturesettings.txt";
-            break;
-        case "accelerationForm":
-            string += "acceleration and jerk/junction deviation tuning"
-            fileName = "accelerationsettings.txt";
-            break;
-    }
-    string += " form\n_________________________________________________________________________\n\n";
+    var string = "";
+    string += "Settings for " + formName.description.value + " form\n";
+    string += "_________________________________________________________________________\n\n";
     string += "G-Code originally generated by Simplify3D(R) Version 4.1.2\nThis calibration test gcode modified by the Teaching Tech Calibration website: https://teachingtechyt.github.io/calibration.html\n";
     string += "All changes are marked in the gcode with 'custom' at the end of each line. Open the gcode in a text editor and search for this to your check inputs if needed.\n\n";
     if(formName.psuon.checked == true) {
@@ -653,6 +629,32 @@ function outputSettings(formName) {
             string += "   B    |    "+formName.accel_b1.value+" mm/sec/sec   |          "+formName.accel_b4.value+"\n";
             string += "   A    |    "+formName.accel_a1.value+" mm/sec/sec   |          "+formName.accel_a4.value+"\n";
         }
-    }  
-    downloadFile(fileName, string);
+    }
+    return string;
+}
+
+
+function downloadGcode(form, fileName) {
+    var gcode = processGcode(form);
+    var settings = outputSettings(form);
+
+    // process finished gcode file
+    if (!fileName) {
+        fileName = form.description.value + ".gcode";
+    }
+
+    var output = "";
+    // prefix each line with ; to indicate comment
+    output += "; " + settings.replaceAll("\n", "\n; ");
+    output += gcode;
+    downloadFile(fileName, output);
+}
+
+function downloadSettings(form, fileName) {
+    var settings = outputSettings(form);
+
+    if (!fileName) {
+        fileName = form.description.value + "settings.txt";
+    }
+    downloadFile(fileName, settings);
 }