From d137384088d31dbb71f4b07884bbf4d6259503af Mon Sep 17 00:00:00 2001 From: Yaroslav Kosterin Date: Thu, 16 Jan 2025 10:55:37 +0200 Subject: [PATCH 01/15] add fund request criteria steps browser tests --- .../forms/ui-controls/UIControlCheckbox.tsx | 3 +++ .../forms/ui-controls/UIControlDate.tsx | 4 +++- .../forms/ui-controls/UIControlStep.tsx | 5 +++++ .../pages/funds-activate/FundActivate.tsx | 8 +++++++- .../pages/funds-request/FundRequest.tsx | 2 +- .../elements/FundRequestGoBackButton.tsx | 2 ++ .../steps/FundRequestStepConfirmCriteria.tsx | 1 + .../elements/steps/FundRequestStepCriteria.tsx | 16 +++++++++++++++- .../steps/FundRequestStepCriteriaOverview.tsx | 3 ++- .../elements/steps/FundRequestStepDone.tsx | 2 +- .../steps/FundRequestValuesOverview.tsx | 1 + .../components/pages/funds-show/FundsShow.tsx | 17 ++++++++++++++++- 12 files changed, 57 insertions(+), 7 deletions(-) diff --git a/react/src/dashboard/components/elements/forms/ui-controls/UIControlCheckbox.tsx b/react/src/dashboard/components/elements/forms/ui-controls/UIControlCheckbox.tsx index 96068bc75..ff4f25ac9 100644 --- a/react/src/dashboard/components/elements/forms/ui-controls/UIControlCheckbox.tsx +++ b/react/src/dashboard/components/elements/forms/ui-controls/UIControlCheckbox.tsx @@ -10,6 +10,7 @@ export default function UIControlCheckbox({ slim = false, className = '', disabled = false, + dataDusk = null, onChange = null, onChangeValue = null, }: { @@ -21,6 +22,7 @@ export default function UIControlCheckbox({ checked?: boolean; className?: string; disabled?: boolean; + dataDusk?: string; onChange?: (e: React.ChangeEvent) => void; onChangeValue?: (checked: boolean) => void; }) { @@ -59,6 +61,7 @@ export default function UIControlCheckbox({ htmlFor={innerId} tabIndex={0} aria-checked={inputRef?.current?.checked} + data-dusk={dataDusk} onKeyDown={toggleCheckbox}> diff --git a/react/src/dashboard/components/elements/forms/ui-controls/UIControlDate.tsx b/react/src/dashboard/components/elements/forms/ui-controls/UIControlDate.tsx index cc72f6d92..e393afdbb 100644 --- a/react/src/dashboard/components/elements/forms/ui-controls/UIControlDate.tsx +++ b/react/src/dashboard/components/elements/forms/ui-controls/UIControlDate.tsx @@ -10,6 +10,7 @@ export default function UIControlDate({ onChange, placeholder = null, className, + dataDusk = null, }: { id?: string; dateMin?: Date; @@ -19,13 +20,14 @@ export default function UIControlDate({ onChange: (date?: Date) => void; placeholder?: string; className?: string; + dataDusk?: string; }) { const reset = useCallback(() => { onChange(null); }, [onChange]); return ( -
+
(e.key == 'Enter' ? decrease() : null)} onClick={decrease} @@ -52,6 +56,7 @@ export default function UIControlStep({
{value?.toString()}
(e.key == 'Enter' ? increase() : null)} onClick={increase} diff --git a/react/src/webshop/components/pages/funds-activate/FundActivate.tsx b/react/src/webshop/components/pages/funds-activate/FundActivate.tsx index 03b9b63e0..3f60031ca 100644 --- a/react/src/webshop/components/pages/funds-activate/FundActivate.tsx +++ b/react/src/webshop/components/pages/funds-activate/FundActivate.tsx @@ -438,7 +438,7 @@ export default function FundActivate() { } if (options[0] === 'request') { - return navigateState('fund-request', fund); + return navigateState('fund-request', fund, {}, { state: { from: 'fund-activate' } }); } if (options.length === 1 && options[0] !== 'digid') { @@ -574,6 +574,7 @@ export default function FundActivate() {
{options?.includes('code') && (
setState('code')} onKeyDown={clickOnKeyEnter} @@ -598,6 +599,7 @@ export default function FundActivate() { {options?.includes('digid') && (
selectDigiDOption(fund)} onKeyDown={clickOnKeyEnter} @@ -624,8 +626,10 @@ export default function FundActivate() {
) : ( - ) diff --git a/react/src/webshop/components/pages/funds-request/elements/steps/FundRequestStepCriteriaOverview.tsx b/react/src/webshop/components/pages/funds-request/elements/steps/FundRequestStepCriteriaOverview.tsx index bae934980..c72dfb1f5 100644 --- a/react/src/webshop/components/pages/funds-request/elements/steps/FundRequestStepCriteriaOverview.tsx +++ b/react/src/webshop/components/pages/funds-request/elements/steps/FundRequestStepCriteriaOverview.tsx @@ -28,7 +28,7 @@ export default function FundRequestStepCriteriaOverview({ {progress} -
+

{translate('fund_request.sign_up.pane.header_title')}

@@ -66,6 +66,7 @@ export default function FundRequestStepCriteriaOverview({ onClick={onNextStep} role="button" type="button" + data-dusk="nextStepButton" tabIndex={0}> {translate('fund_request.sign_up.pane.footer.next')} diff --git a/react/src/webshop/components/pages/funds-request/elements/steps/FundRequestStepDone.tsx b/react/src/webshop/components/pages/funds-request/elements/steps/FundRequestStepDone.tsx index f1e267c40..e9f017a65 100644 --- a/react/src/webshop/components/pages/funds-request/elements/steps/FundRequestStepDone.tsx +++ b/react/src/webshop/components/pages/funds-request/elements/steps/FundRequestStepDone.tsx @@ -47,7 +47,7 @@ export default function FundRequestStepDone({
) : ( -
+

Aanvraag ontvangen

diff --git a/react/src/webshop/components/pages/funds-request/elements/steps/FundRequestValuesOverview.tsx b/react/src/webshop/components/pages/funds-request/elements/steps/FundRequestValuesOverview.tsx index d968f9d4f..90d367287 100644 --- a/react/src/webshop/components/pages/funds-request/elements/steps/FundRequestValuesOverview.tsx +++ b/react/src/webshop/components/pages/funds-request/elements/steps/FundRequestValuesOverview.tsx @@ -139,6 +139,7 @@ export default function FundRequestValuesOverview({ className="button button-primary button-sm" onClick={onSubmitRequest} role="button" + data-dusk="submitButton" tabIndex={0}> Vraag aan diff --git a/react/src/webshop/components/pages/funds-show/FundsShow.tsx b/react/src/webshop/components/pages/funds-show/FundsShow.tsx index 95bfba5c2..8db956074 100644 --- a/react/src/webshop/components/pages/funds-show/FundsShow.tsx +++ b/react/src/webshop/components/pages/funds-show/FundsShow.tsx @@ -153,7 +153,9 @@ export default function FundsShow() {