NVMe2K is not a Plug and Play compliant driver

[red-ray]

After looking at the code I suspected NVMe2K was not a Plug and Play compliant driver as I suspected it was scanning the PCI bus on Windows 2000, to be Plug and Play compliant it MUST not do this, in fact that code should be compiled out!

To check my suspicions I booted W2K, uninstalled all the NVMe2K controllers and NVMe Disk Drives then rebooted with just one NVMe drive installed. When the system had started I ran SIV32X which reported the NVMe SMART information for a controller that had no driver installed for it!

Above you can see there is no driver version and Windows is trying to install the new device, but the controller is active and the NVMe Drive is available. Notice also how Device Manager reports it as a PCI device rather than "NVMe Storage Controller (Windows 2000)".

This is just WRONG and should be be corrected, how on earth did this get through code review?

[LordOfMice]

how on earth did this get through code review?

Because it is attempt to get single code for both NT4(NonPnP) and 2000+(PnP) . And both cases work not good as the result.

More I can say, NT4/"Install time" code has pretty serious problem:
ConfigInfo->SystemIoBusNumber and ConfigInfo->SlotNumber do NOT filled after scan:

    //ConfigInfo->SystemIoBusNumber = busNumber;
    //ConfigInfo->SlotNumber = slotNumber;
    
    return HwFoundAdapter(DevExt, ConfigInfo, pciBuffer);