-
Notifications
You must be signed in to change notification settings - Fork 281
build your first basic workflow experimentation #3994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious why these logos are being added. It looks like all of them are already here.
|
A couple of general questions.
|
| Most applications require multiple coordinated steps - processing payments, sending emails, updating databases. | ||
| This tutorial uses money transfers to demonstrate how Temporal ensures these multi-step processes complete reliably, resuming exactly where they left off even after any failure. | ||
| <div style={{textAlign: 'center', margin: '2rem 0'}}> | ||
| <img src="/img/moneytransfer/money-withdrawal.png" alt="Money Transfer Application Flow" style={{maxWidth: '100%', height: 'auto'}} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
||
| </SetupSteps> | ||
|
|
||
| <details> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing wrong here, just a question. I was wondering why we would use the dropdown here. If this is info that we definitely want the user to see it should probably be a regular section so they don't accidentally skip over it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree - i am inclined to not collapse this information
|
|
||
| <RetryPolicyComparison /> | ||
|
|
||
| :::important This is a Simplified Example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit: should this be a warning just to highlight this? Totally fine if not!
|
|
||
| </SdkTabs> | ||
|
|
||
| This code uses a Temporal Client to connect to the Temporal Service, calling its workflow start method to request execution. This returns a handle, and calling result on that handle will block until execution is complete, at which point it provides the result. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| This code uses a Temporal Client to connect to the Temporal Service, calling its workflow start method to request execution. This returns a handle, and calling result on that handle will block until execution is complete, at which point it provides the result. | |
| This code uses a Temporal Client to connect to the Temporal Service, calling its Workflow start method to request execution. This returns a handle, and calling result on that handle will block until execution is complete, at which point it provides the result. |
|
|
||
| **In Terminal 3, start the Workflow:** | ||
|
|
||
| The workflow starter script starts a Workflow Execution. Each time you run it, the Temporal Server starts a new Workflow Execution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| The workflow starter script starts a Workflow Execution. Each time you run it, the Temporal Server starts a new Workflow Execution. | |
| The Workflow starter script starts a Workflow Execution. Each time you run it, the Temporal Server starts a new Workflow Execution. |
| <CallToAction | ||
| href="http://localhost:8233" | ||
| buttonText="Open the Temporal UI " | ||
| description="View the state of the Workflow with the Temporal Web UI" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have something that says this is running locally?
| - The `withdraw()` Activity completes successfully | ||
| - The `deposit()` Activity fails and retries automatically | ||
|
|
||
| <AnimatedTerminal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this! The only thing is that it makes the page jump when there are new lines in the terminal.
Screen.Recording.2025-12-01.at.11.59.57.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is gorgeous! Great work. My comments are aimed at user-friendliness but may make it less pretty
|
|
||
| Before starting this tutorial: | ||
|
|
||
| - **Set up a local development environment** for developing Temporal applications |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like the prerequisites are a little unclear to those who are new to our site. I know that if users go through the quick starts if they are set, but if I'm a new user, it's not clear if I am supposed to do the setup AND the quickstarts.
If we don't want to create a separate environment setup page, then we should just remove the two bullets and just tell them to do the quickstarts as a prerequisite.
|
|
||
| </SetupSteps> | ||
|
|
||
| <details> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree - i am inclined to not collapse this information
| id: build-your-first-workflow | ||
| title: Build Your First Workflow | ||
| sidebar_label: "Part 1: Build Your First Workflow" | ||
| hide_table_of_contents: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i know that the layout is well designed and we could use the vertical space, but i still think this is a long enough tutorial that it'd be beneficial to have the TOC. It's easier for users to make sense of whey are doing in the context of the whole project. Right now, they can't see more than the H2 heading they are in.

What does this PR do?
https://temporal-documentation-git-tutorial-layout-money-transfe-0fc0c4.preview.thundergun.io/build-your-first-basic-workflow/build-your-first-workflow
Notes to reviewers
files changed include new components for interaction and sdk boxed logos
wip (TODO: make light mode friendly)
aiming for: concise + engaging, dev-to-dev tone, consistent interactions, progressive disclosure.