From 32ea3b31b090e5e4a79fef19178325e1ef505eed Mon Sep 17 00:00:00 2001 From: Nick Beaumont Date: Mon, 1 Dec 2025 16:36:18 -0800 Subject: [PATCH 1/2] Remove broken health checks for now --- proxy/proxy.go | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/proxy/proxy.go b/proxy/proxy.go index e0e2e6ed..fcb8c51d 100644 --- a/proxy/proxy.go +++ b/proxy/proxy.go @@ -125,12 +125,12 @@ func (s *Proxy) Start() error { if s.inboundHealthCheckConfig != nil { var err error healthFn := func() bool { - // TODO: overly conservative right now. When there are multiple remotes, we should track their health separately - for _, cc := range s.clusterConnections { - if !cc.AcceptingInboundTraffic() { - return false - } - } + // TODO: Rethink health checks. The inbound/outbound traffic availability isn't quite right for a health check + // for _, cc := range s.clusterConnections { + // if !cc.AcceptingInboundTraffic() { + // return false + // } + // } return true } if s.inboundHealthCheckServer, err = s.startHealthCheckHandler(s.lifetime, newInboundHealthCheck(healthFn, s.logger), *s.inboundHealthCheckConfig); err != nil { @@ -143,12 +143,12 @@ func (s *Proxy) Start() error { if s.outboundHealthCheckConfig != nil { healthFn := func() bool { - // TODO: overly conservative right now. When there are multiple remotes, we should track their health separately - for _, cc := range s.clusterConnections { - if !cc.AcceptingOutboundTraffic() { - return false - } - } + // TODO: Rethink health checks. The inbound/outbound traffic availability isn't quite right for a health check + // for _, cc := range s.clusterConnections { + // if !cc.AcceptingOutboundTraffic() { + // return false + // } + // } return true } var err error From 5cd7f3d325d8613c304afced34aeae71ce896aba Mon Sep 17 00:00:00 2001 From: Nick Beaumont Date: Tue, 2 Dec 2025 09:47:19 -0800 Subject: [PATCH 2/2] Remove unused code --- proxy/proxy.go | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/proxy/proxy.go b/proxy/proxy.go index fcb8c51d..bba7ee9c 100644 --- a/proxy/proxy.go +++ b/proxy/proxy.go @@ -126,11 +126,6 @@ func (s *Proxy) Start() error { var err error healthFn := func() bool { // TODO: Rethink health checks. The inbound/outbound traffic availability isn't quite right for a health check - // for _, cc := range s.clusterConnections { - // if !cc.AcceptingInboundTraffic() { - // return false - // } - // } return true } if s.inboundHealthCheckServer, err = s.startHealthCheckHandler(s.lifetime, newInboundHealthCheck(healthFn, s.logger), *s.inboundHealthCheckConfig); err != nil { @@ -144,11 +139,6 @@ func (s *Proxy) Start() error { if s.outboundHealthCheckConfig != nil { healthFn := func() bool { // TODO: Rethink health checks. The inbound/outbound traffic availability isn't quite right for a health check - // for _, cc := range s.clusterConnections { - // if !cc.AcceptingOutboundTraffic() { - // return false - // } - // } return true } var err error