From cf2062284f7fc9d46f8a9df3b3ae9f4238f60fb9 Mon Sep 17 00:00:00 2001 From: Spencer Judge Date: Tue, 31 Mar 2026 11:56:42 -0700 Subject: [PATCH 1/2] Claude fix all docstring problems & add check to CI --- .github/workflows/ci.yml | 26 ++++++++++++++++++- .gitignore | 4 ++- gradle/java.gradle | 5 ++-- .../io/temporal/envconfig/ClientConfig.java | 2 +- .../codec/AbstractRemoteDataEncoderCodec.java | 2 -- .../io/temporal/activity/ActivityInfo.java | 4 +-- .../temporal/activity/ActivityInterface.java | 2 -- .../io/temporal/client/WorkflowClient.java | 15 +++++------ .../temporal/client/WorkflowClientPlugin.java | 8 +++--- .../client/WorkflowExecutionDescription.java | 8 +++--- .../io/temporal/client/WorkflowOptions.java | 2 +- .../java/io/temporal/client/WorkflowStub.java | 15 +++++------ .../ScheduleActionStartWorkflow.java | 6 ++--- .../WorkflowInboundCallsInterceptor.java | 6 ++--- .../WorkflowOutboundCallsInterceptor.java | 4 +-- .../io/temporal/internal/package-info.java | 4 +-- .../internal/task/VirtualThreadDelegate.java | 2 +- .../main/java/io/temporal/worker/Worker.java | 4 --- .../temporal/worker/WorkerFactoryOptions.java | 6 ++--- .../java/io/temporal/worker/WorkerPlugin.java | 4 +-- .../worker/WorkflowTaskDispatchHandle.java | 3 ++- .../worker/tuning/SlotReserveContext.java | 2 +- .../java/io/temporal/workflow/Workflow.java | 15 +++++------ .../io/temporal/workflow/WorkflowInfo.java | 12 ++++----- .../temporal/workflow/WorkflowInterface.java | 2 -- .../io/temporal/workflow/WorkflowLocal.java | 18 ++++++------- .../workflow/WorkflowThreadLocal.java | 18 ++++++------- .../workflow/unsafe/WorkflowUnsafe.java | 4 +-- .../temporal/internal/BackoffThrottler.java | 2 -- .../CheckedExceptionWrapper.java | 4 +-- .../testservice/TestWorkflowService.java | 2 +- 31 files changed, 109 insertions(+), 102 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 964d0d9883..8846e4e0a4 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -191,7 +191,7 @@ jobs: - name: Set up Java uses: actions/setup-java@v5 with: - java-version: "11" + java-version: "23" distribution: "temurin" - name: Set up Gradle @@ -200,6 +200,30 @@ jobs: - name: Run copyright and code format checks run: ./gradlew --no-daemon spotlessCheck + javadoc: + name: Javadoc + runs-on: ubuntu-latest + timeout-minutes: 20 + steps: + - name: Checkout repo + uses: actions/checkout@v5 + with: + fetch-depth: 0 + submodules: recursive + ref: ${{ github.event.pull_request.head.sha }} + + - name: Set up Java + uses: actions/setup-java@v5 + with: + java-version: "23" + distribution: "temurin" + + - name: Set up Gradle + uses: gradle/actions/setup-gradle@v5 + + - name: Run javadoc + run: ./gradlew --no-daemon javadoc + build_native_images: name: Build native test server uses: ./.github/workflows/build-native-image.yml diff --git a/.gitignore b/.gitignore index ef1d5524bd..619d53f221 100644 --- a/.gitignore +++ b/.gitignore @@ -18,4 +18,6 @@ src/main/idls/* .settings .vscode/ */bin -/.claude \ No newline at end of file +/.claude +mise.local.toml +**/.factorypath diff --git a/gradle/java.gradle b/gradle/java.gradle index d968e5ff1d..fbf17a925a 100644 --- a/gradle/java.gradle +++ b/gradle/java.gradle @@ -32,9 +32,8 @@ subprojects { javadoc { options.encoding = 'UTF-8' - if (JavaVersion.current().isJava8Compatible()) { - options.addStringOption('Xdoclint:none', '-quiet') - } + options.addStringOption('Xdoclint:reference', '-quiet') + options.addBooleanOption('Werror', true) if (JavaVersion.current().isJava9Compatible()) { options.addBooleanOption('html5', true) } diff --git a/temporal-envconfig/src/main/java/io/temporal/envconfig/ClientConfig.java b/temporal-envconfig/src/main/java/io/temporal/envconfig/ClientConfig.java index 30dfa9b436..50051b57a7 100644 --- a/temporal-envconfig/src/main/java/io/temporal/envconfig/ClientConfig.java +++ b/temporal-envconfig/src/main/java/io/temporal/envconfig/ClientConfig.java @@ -172,7 +172,7 @@ public static ClientConfig fromToml(byte[] tomlData, ClientConfigFromTomlOptions * * @param config the client config to convert * @return the TOML data as bytes - * @apiNote The output will not be identical to the input if the config was loaded from a file + *

Note: The output will not be identical to the input if the config was loaded from a file * because comments and formatting are not preserved. */ public static byte[] toTomlAsBytes(ClientConfig config) throws IOException { diff --git a/temporal-remote-data-encoder/src/main/java/io/temporal/payload/codec/AbstractRemoteDataEncoderCodec.java b/temporal-remote-data-encoder/src/main/java/io/temporal/payload/codec/AbstractRemoteDataEncoderCodec.java index a70f651bb1..cf02f24f35 100644 --- a/temporal-remote-data-encoder/src/main/java/io/temporal/payload/codec/AbstractRemoteDataEncoderCodec.java +++ b/temporal-remote-data-encoder/src/main/java/io/temporal/payload/codec/AbstractRemoteDataEncoderCodec.java @@ -11,8 +11,6 @@ /** * Performs encoding/decoding of the payloads via the Remote Data Encoder (RDE) available over http. * - *

- * *

Remote Data Encoder Http Server specification

* *

RDE Server must: diff --git a/temporal-sdk/src/main/java/io/temporal/activity/ActivityInfo.java b/temporal-sdk/src/main/java/io/temporal/activity/ActivityInfo.java index 40d8d78af7..d161c8361c 100644 --- a/temporal-sdk/src/main/java/io/temporal/activity/ActivityInfo.java +++ b/temporal-sdk/src/main/java/io/temporal/activity/ActivityInfo.java @@ -126,8 +126,8 @@ public interface ActivityInfo { /** * Return the priority of the activity task. * - * @apiNote If unset or on an older server version, this method will return {@link - * Priority#getDefaultInstance()}. + *

Note: If unset or on an older server version, this method will return {@link + * Priority#getDefaultInstance()}. */ @Experimental @Nonnull diff --git a/temporal-sdk/src/main/java/io/temporal/activity/ActivityInterface.java b/temporal-sdk/src/main/java/io/temporal/activity/ActivityInterface.java index 0a7b01e87d..9cfb5ee975 100644 --- a/temporal-sdk/src/main/java/io/temporal/activity/ActivityInterface.java +++ b/temporal-sdk/src/main/java/io/temporal/activity/ActivityInterface.java @@ -42,8 +42,6 @@ * When CImpl instance is registered with the {@link io.temporal.worker.Worker} the * following activities are registered: * - *

- * *