upload nightly tps metrics to s3 #1242
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| DATE=$(date +%Y-%m-%d) | ||
| # Use test/ prefix on non-main branches | ||
| PREFIX="language=python/date=$DATE" | ||
| if [[ "${{ github.ref }}" != "refs/heads/main" ]]; then |
Contributor
There was a problem hiding this comment.
I think github.ref might be safe in this context, but IMO we should be in the habit of piping any interpolation through env vars to avoid any potential injection
|
|
||
| - name: Install Prometheus | ||
| run: | | ||
| PROM_VERSION="3.8.0" |
Contributor
There was a problem hiding this comment.
I'd consider moving this up to the env block (either for this step or even the workflow) rather than defining it inline here.
Contributor
Author
There was a problem hiding this comment.
Also moved to env var
VegetarianOrc
approved these changes
Dec 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Upload nightly prometheus worker metrics to S3 for querying in Omni
Why?
observability