Simplify Config Templating #8685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaptersix
commented
Dec 4, 2025
| log: | ||
| stdout: true | ||
| level: {{ default .Env.LOG_LEVEL "info" }} | ||
| level: {{ default "info" (env "LOG_LEVEL") }} |
Contributor
Author
There was a problem hiding this comment.
This is worth looking at. (Hidden by Github do to the large number of changes)
chaptersix
commented
Dec 4, 2025
common/config/config_test.go
Outdated
|
|
||
| func TestEmbeddedTemplateOnlyDiffersFromDockerByComment(t *testing.T) { | ||
| embeddedContent, err := os.ReadFile("config_template_embedded.yaml") | ||
| func TestEmbeddedTemplateConsistentWithDockerTemplate(t *testing.T) { |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| func TestEmbeddedTemplateConsistentWithDockerTemplate(t *testing.T) { | |
| func TestEmbeddedTemplateConsistentWithDockerTemplate(t *testing.T) { |
this test in no longer relevant since there's a syntax different between the 2 files. docker-builds still expects the dockerize syntax.
chaptersix
commented
Dec 4, 2025
|
|
||
| var rendered bytes.Buffer | ||
| err = tpl.Execute(&rendered, ctx) | ||
| err = tpl.Execute(&rendered, nil) |
Contributor
Author
There was a problem hiding this comment.
no need to pass in the environment as context
chaptersix
commented
Dec 4, 2025
| and [base-builder](https://github.com/temporalio/docker-builds/blob/main/docker/base-images/base-builder.Dockerfile)~~ | ||
| **Note:** The docker-builds repository is now deprecated and will be archived. | ||
| <!-- TODO: Remove docker/config_template.yaml after temporalio/docker-builds repository is archived --> |
Contributor
Author
There was a problem hiding this comment.
note is already in the file and this does not render.
bergundy
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
dockerizesyntax. Now we just supportsprigWhy?
Simplification
How did you test it?
Potential risks
Existing config templates will need to be updated to use
sprigonly syntax. Otherwise the server will not be able to read it.