fix(dnspod): [123456789] support filter_at_ns (#3585)

* support filter_at_ns

* add changelog

* update filter schema

---------

Co-authored-by: mikatong <mikatong@tencent.com>

Author: tongyiming

.changelog/3585.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+data-source/tencentcloud_dnspod_record_list: support `filter_at_ns`
+```

schema/filter.json

@@ -93,6 +93,33 @@
                                     },
                                     "required": true,
                                     "description": ""
+                                },
+                                "filter_at_ns": {
+                                    "type": "bool",
+                                    "metadata": {
+                                        "filter": {
+                                            "enable": true
+                                        },
+                                        "values": [
+                                            {
+                                                "value": true,
+                                                "display_name": "是"
+                                            }
+                                        ],
+                                        "widget": "select",
+                                        "val_source": {
+                                            "values": {}
+                                        },
+                                        "description": "是否过滤主机记录为 @ 的 NS 记录",
+                                        "display_name": "是否过滤主机记录为 @ 的 NS 记录",
+                                        "default_value": {
+                                            "value": true,
+                                            "display_name": "是"
+                                        },
+                                        "is_not_edited": true
+                                    },
+                                    "required": true,
+                                    "description": ""
                                 }
                             }
                         },

tencentcloud/services/dnspod/data_source_tc_dnspod_record_list.go

@@ -169,6 +169,13 @@ func DataSourceTencentCloudDnspodRecordList() *schema.Resource {
 				Description: "Project ID.",
 			},
 
+			"filter_at_ns": {
+				Optional:    true,
+				Type:        schema.TypeBool,
+				Description: "Filter @ type NS records. Default is false.",
+				Default:     false,
+			},
+
 			"record_count_info": {
 				Computed:    true,
 				Type:        schema.TypeList,
@@ -484,7 +491,10 @@ func dataSourceTencentCloudDnspodRecordListRead(d *schema.ResourceData, meta int
 	if v, ok := d.GetOkExists("project_id"); ok {
 		paramMap["ProjectId"] = helper.IntInt64(v.(int))
 	}
-
+	var filterAtNS bool
+	if v, ok := d.GetOkExists("filter_at_ns"); ok {
+		filterAtNS = v.(bool)
+	}
 	service := DnspodService{client: meta.(tccommon.ProviderMeta).GetAPIV3Conn()}
 
 	var recordList []*dnspod.RecordListItem
@@ -536,6 +546,9 @@ func dataSourceTencentCloudDnspodRecordListRead(d *schema.ResourceData, meta int
 	instanceList := make([]map[string]interface{}, 0, len(recordList))
 	if recordList != nil {
 		for _, recordListItem := range recordList {
+			if filterAtNS && recordListItem.Name != nil && *recordListItem.Name == DNSPOD_RECORD_NAME_AT && recordListItem.Type != nil && *recordListItem.Type == DNSPOD_RECORD_TYPE_NS {
+				continue
+			}
 			recordListItemMap := map[string]interface{}{}
 			instanceListItemMap := map[string]interface{}{}
 			instanceListItemMap["domain"] = domain

tencentcloud/services/dnspod/data_source_tc_dnspod_record_list_test.go

@@ -58,10 +58,36 @@ func TestAccTencentCloudDnspodRecordListDataSource_withoutSubDomain(t *testing.T
 	})
 }
 
+func TestAccTencentCloudDnspodRecordListDataSource_filterAtNS(t *testing.T) {
+	t.Parallel()
+	resource.Test(t, resource.TestCase{
+		PreCheck:  func() { tcacctest.AccPreCheck(t) },
+		Providers: tcacctest.AccProviders,
+		Steps: []resource.TestStep{
+			{
+				Config: testAccDnspodRecordListDataSource_filterAtNSTrue,
+				Check: resource.ComposeTestCheckFunc(
+					tcacctest.AccCheckTencentCloudDataSourceID("data.tencentcloud_dnspod_record_list.subdomains"),
+					resource.TestCheckResourceAttr("data.tencentcloud_dnspod_record_list.subdomains", "record_list.#", "0"),
+					resource.TestCheckResourceAttr("data.tencentcloud_dnspod_record_list.subdomains", "instance_list.#", "0"),
+				),
+			},
+			{
+				Config: testAccDnspodRecordListDataSource_filterAtNSFalse,
+				Check: resource.ComposeTestCheckFunc(
+					tcacctest.AccCheckTencentCloudDataSourceID("data.tencentcloud_dnspod_record_list.subdomains"),
+					resource.TestCheckResourceAttr("data.tencentcloud_dnspod_record_list.subdomains", "record_list.#", "2"),
+					resource.TestCheckResourceAttr("data.tencentcloud_dnspod_record_list.subdomains", "instance_list.#", "2"),
+				),
+			},
+		},
+	})
+}
+
 const testAccDnspodRecordListDataSource = `
 
 data "tencentcloud_dnspod_record_list" "record_list" {
-  domain = "iac-tf.cloud"
+  domain = "tencentcloud-terraform-provider.cn"
   # domain_id = 123
   # sub_domain = "www"
   record_type = ["A", "NS", "CNAME", "NS", "AAAA"]
@@ -101,3 +127,20 @@ data "tencentcloud_dnspod_record_list" "subdomains" {
   is_exact_sub_domain = true
 }
 `
+
+const testAccDnspodRecordListDataSource_filterAtNSTrue = `
+data "tencentcloud_dnspod_record_list" "subdomains" {
+  domain              = "tencentcloud-terraform-provider.cn"
+  sub_domains = ["@"]
+  record_type = ["NS"]
+  filter_at_ns = true
+}
+`
+const testAccDnspodRecordListDataSource_filterAtNSFalse = `
+data "tencentcloud_dnspod_record_list" "subdomains" {
+  domain              = "tencentcloud-terraform-provider.cn"
+  sub_domains = ["@"]
+  record_type = ["NS"]
+  filter_at_ns = false
+}
+`

tencentcloud/services/dnspod/extension_dnspod.go

@@ -19,3 +19,8 @@ var DNSPOD_DOMAIN_STATUS_TYPE = []string{
 	DNSPOD_DOMAIN_STATUS_ENABLE,
 	DNSPOD_DOMAIN_STATUS_DISABLE,
 }
+
+const (
+	DNSPOD_RECORD_NAME_AT = "@"
+	DNSPOD_RECORD_TYPE_NS = "NS"
+)

website/docs/d/dnspod_record_list.html.markdown

@@ -46,6 +46,7 @@ The following arguments are supported:
 
 * `domain` - (Required, String) The domain to which the resolution record belongs.
 * `domain_id` - (Optional, Int) The domain ID to which the resolution record belongs. If DomainId is provided, the system will ignore the Domain parameter. You can find all Domain and DomainId through the DescribeDomainList interface.
+* `filter_at_ns` - (Optional, Bool) Filter @ type NS records. Default is false.
 * `group_id` - (Optional, Set: [`Int`]) When retrieving resolution records under certain groups, pass this group ID. You can obtain the GroupId field through the DescribeRecordGroupList interface.
 * `is_exact_sub_domain` - (Optional, Bool) Whether to perform an exact search based on the SubDomain parameter.
 * `keyword` - (Optional, String) Search for resolution records by keyword, currently supporting searching host headers and record values.