fixes negative length bug - fixes #12

filipjonckers · filipjonckers · commit c1ce2bd6cf05 · 2022-01-06T02:20:43.000+01:00
diff --git a/src/main/java/aero/t2s/modes/decoder/Common.java b/src/main/java/aero/t2s/modes/decoder/Common.java
@@ -106,6 +106,9 @@ public static short[] getParity(short[] data) {
     }
 
     public static boolean isNotValid(short[] data) {
+        if(data.length < 3) {
+            return false;  // fixes negative length bug where data is only 2 bytes (16bit Mode A/C replies, ACAS, ...)
+        }
         short[] payload = Arrays.copyOfRange(data, 0, data.length - 3);
         short[] parity = Arrays.copyOfRange(data, data.length - 3, data.length);
 

Original file line number	Diff line number	Diff line change
`@@ -106,6 +106,9 @@ public static short[] getParity(short[] data) {`
`106`	`106`	`}`
`107`	`107`
`108`	`108`	`public static boolean isNotValid(short[] data) {`
	`109`	`+ if(data.length < 3) {`
	`110`	`+ return false; // fixes negative length bug where data is only 2 bytes (16bit Mode A/C replies, ACAS, ...)`
	`111`	`+ }`
`109`	`112`	`short[] payload = Arrays.copyOfRange(data, 0, data.length - 3);`
`110`	`113`	`short[] parity = Arrays.copyOfRange(data, data.length - 3, data.length);`
`111`	`114`