fix(queries): fix boolean values for getBy* queries

56

Author: Brandon Carroll

src/__tests__/misc.js

@@ -1,5 +1,5 @@
 import React from 'react';
-import { Button, Picker, Text, View } from 'react-native';
+import { Button, Picker, Switch, Text, View } from 'react-native';
 import { toMatchDiffSnapshot } from 'snapshot-diff';
 
 import { cleanup, fireEvent, render } from '../';
@@ -83,3 +83,9 @@ test('it finds only valid parents', () => {
   expect(getByText('hey').parentNode.parentNode.props.testID).toBe('view');
   expect(baseElement.parentNode).toBeNull();
 });
+
+test('it finds <Switch /> by value={false}', () => {
+  const { getByDisplayValue } = render(<Switch value={false} />);
+
+  getByDisplayValue(false);
+});

src/lib/__tests__/matches.js

@@ -22,3 +22,8 @@ test('matchers return false if text to match is not a string', () => {
   expect(matches(null, node, 'ABC', normalizer)).toBe(false);
   expect(fuzzyMatches(null, node, 'ABC', normalizer)).toBe(false);
 });
+
+test('matchers return true if text to match is a boolean', () => {
+  expect(matches(true, node, true, normalizer)).toBe(true);
+  expect(fuzzyMatches(1, node, true, normalizer)).toBe(true);
+});

src/lib/__tests__/misc.js

@@ -1,5 +1,5 @@
 import React from 'react';
-import { View } from 'react-native';
+import { Picker, Switch, View } from 'react-native';
 
 import { render, queryByProp, queryByTestId, cleanup } from '../../';
 
@@ -20,3 +20,16 @@ test('queryByProp', () => {
     /multiple elements/,
   );
 });
+
+it('should render test', () => {
+  const { getByDisplayValue } = render(
+    <View>
+      <Picker selectedValue="fr">
+        <Picker.Item value="fr" label="French" />
+      </Picker>
+      <Switch value={true} />
+    </View>,
+  );
+
+  expect(getByDisplayValue(true)).toBeTruthy();
+});

src/lib/matches.js

@@ -1,8 +1,12 @@
 function fuzzyMatches(textToMatch, node, matcher, normalizer) {
-  if (typeof textToMatch !== 'string') {
+  if (typeof matcher === 'boolean') {
     return textToMatch == matcher;
   }
 
+  if (!textToMatch) {
+    return false;
+  }
+
   const normalizedText = normalizer(textToMatch);
   if (typeof matcher === 'string') {
     return normalizedText.toLowerCase().includes(matcher.toLowerCase());
@@ -14,10 +18,14 @@ function fuzzyMatches(textToMatch, node, matcher, normalizer) {
 }
 
 function matches(textToMatch, node, matcher, normalizer) {
-  if (typeof textToMatch !== 'string') {
+  if (typeof matcher === 'boolean') {
     return textToMatch === matcher;
   }
 
+  if (!textToMatch) {
+    return false;
+  }
+
   const normalizedText = normalizer(textToMatch);
   if (typeof matcher === 'string') {
     return normalizedText === matcher;