Skip to content

Commit 5b6cd61

Browse files
Merge pull request #13 from testing-library/fix-sync-query-errors-producing-logs
fix: expected getBy query errors being logged
2 parents 07070a1 + 881d464 commit 5b6cd61

File tree

3 files changed

+26
-22
lines changed

3 files changed

+26
-22
lines changed

src/index.ts

Lines changed: 24 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -108,26 +108,30 @@ function executeQuery(
108108

109109
const [matcher, options, waitForOptions] = args.map(deserializeArg)
110110

111-
Promise.resolve(
112-
window.TestingLibraryDom[query](
113-
container,
114-
matcher,
115-
options,
116-
waitForOptions,
117-
),
118-
)
119-
.then((result) => {
120-
if (!result) {
121-
return done(null)
122-
}
123-
if (Array.isArray(result)) {
124-
return done(
125-
result.map((element) => ({selector: window.Simmer(element)})),
126-
)
127-
}
128-
return done({selector: window.Simmer(result)})
129-
})
130-
.catch((e) => done(e.message))
111+
try {
112+
Promise.resolve(
113+
window.TestingLibraryDom[query](
114+
container,
115+
matcher,
116+
options,
117+
waitForOptions,
118+
),
119+
)
120+
.then((result) => {
121+
if (!result) {
122+
return done(null)
123+
}
124+
if (Array.isArray(result)) {
125+
return done(
126+
result.map((element) => ({selector: window.Simmer(element)})),
127+
)
128+
}
129+
return done({selector: window.Simmer(result)})
130+
})
131+
.catch((e) => done(e.message))
132+
} catch (e) {
133+
done(e.message)
134+
}
131135
}
132136

133137
function createQuery(element: ElementBase, queryName: string) {

test/async/configure.e2e.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ describe('configure', () => {
4747
await expect(() =>
4848
getByTestId('button-that-should-not-use-testid'),
4949
).rejects.toThrowError(
50-
'TestingLibraryElementError: A better query is available',
50+
'A better query is available',
5151
)
5252
})
5353

wdio.conf.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ exports.config = {
7777
// Define all options that are relevant for the WebdriverIO instance here
7878
//
7979
// Level of logging verbosity: trace | debug | info | warn | error | silent
80-
logLevel: 'silent',
80+
logLevel: 'warn',
8181
//
8282
// Set specific log levels per logger
8383
// loggers:

0 commit comments

Comments
 (0)