From 780bb4d8e2241a6af3fbd20dcd86b28201ff60c7 Mon Sep 17 00:00:00 2001 From: tfrommen Date: Sat, 26 Mar 2016 20:41:06 +0100 Subject: [PATCH] Use constructor injection. --- js/1-bad-practices/src/incomplete-initialization.js | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/js/1-bad-practices/src/incomplete-initialization.js b/js/1-bad-practices/src/incomplete-initialization.js index 0f165bb..b97cb2f 100644 --- a/js/1-bad-practices/src/incomplete-initialization.js +++ b/js/1-bad-practices/src/incomplete-initialization.js @@ -1,11 +1,5 @@ -function Renderer() { - var formatter; - - this.setFormatter = function( f ) { - formatter = f; - }; - - this.getFormattedData = function( data ) { // <-- SUT +function Renderer( formatter ) { + this.getFormattedData = function( data ) { return formatter.format( data ); }; }