🐛 Fix optional declared before required parameter in findOneBy with UNIQUE

Given UNIQUE(a INT, ?b INT, c INT) this fixes the collowing case:
```diff
-findOneByAAndBAndC(int $a, ?int $b = null, int $c)
+findOneByAAndBAndC(int $a, ?int $b, int $c)
```

Cleanup dead code

This as-well fix deprecation:
- `createSchema` becomes `introspectSchema`
- `${var}` becomes `{$var}`

Author: homersimpsons

src/SchemaVersionControl/SchemaVersionControlService.php

@@ -57,7 +57,7 @@ public function dumpSchema(): void
     {
         $schemaManager = $this->connection->createSchemaManager();
         $schemaConfig = $schemaManager->createSchemaConfig();
-        $schema = $schemaManager->createSchema();
+        $schema = $schemaManager->introspectSchema();
         $normalizer = new SchemaNormalizer();
         $desc = $normalizer->normalize($schema, $schemaConfig);
         $yamlSchema = Yaml::dump(['schema' => $desc], 10, 2);

src/Utils/BeanDescriptor.php

@@ -1292,7 +1292,6 @@ private function removeDuplicateIndexes(array $indexes): array
     private function generateFindByDaoCodeForIndex(Index $index, string $beanNamespace, string $beanClassName): ?MethodGenerator
     {
         $columns = $index->getColumns();
-        $usedBeans = [];
 
         /**
          * The list of elements building this index (expressed as columns or foreign keys)
@@ -1318,42 +1317,23 @@ private function generateFindByDaoCodeForIndex(Index $index, string $beanNamespa
         }
 
         $parameters = [];
-        //$functionParameters = [];
         $first = true;
         /** @var AbstractBeanPropertyDescriptor $element */
         foreach ($elements as $element) {
             $parameter = new ParameterGenerator(ltrim($element->getSafeVariableName(), '$'));
-            if (!$first && !($element->isCompulsory() && $index->isUnique())) {
-                $parameterType = '?';
-                //$functionParameter = '?';
-            } else {
-                $parameterType = '';
-                //$functionParameter = '';
-            }
+
+            $parameterType = !$first && (!$index->isUnique() || !$element->isCompulsory()) ? '?' : '';
             $parameterType .= $element->getPhpType();
             $parameter->setType($parameterType);
-            if (!$first && !($element->isCompulsory() && $index->isUnique())) {
+
+            if (!$first && !$index->isUnique()) {
                 $parameter->setDefaultValue(null);
             }
-            //$functionParameter .= $element->getPhpType();
-            $elementClassName = $element->getClassName();
-            if ($elementClassName) {
-                $usedBeans[] = $beanNamespace.'\\'.$elementClassName;
-            }
-            //$functionParameter .= ' '.$element->getVariableName();
-            if ($first) {
-                $first = false;
-            } /*else {
-                $functionParameter .= ' = null';
-            }*/
-            //$functionParameters[] = $functionParameter;
+
             $parameters[] = $parameter;
+            $first = false;
         }
 
-        //$functionParametersString = implode(', ', $functionParameters);
-
-        $count = 0;
-
         $params = [];
         $filterArrayCode = '';
         $commentArguments = [];
@@ -1375,12 +1355,11 @@ private function generateFindByDaoCodeForIndex(Index $index, string $beanNamespa
             } elseif ($element instanceof ObjectBeanPropertyDescriptor) {
                 $foreignKey = $element->getForeignKey();
                 $columns = array_combine($foreignKey->getUnquotedLocalColumns(), $foreignKey->getUnquotedForeignColumns());
-                ++$count;
                 $foreignTable = $this->schema->getTable($foreignKey->getForeignTableName());
                 foreach ($columns as $localColumn => $foreignColumn) {
                     // TODO: a foreign key could point to another foreign key. In this case, there is no getter for the pointed column. We don't support this case.
                     $targetedElement = new ScalarBeanPropertyDescriptor($foreignTable, $foreignTable->getColumn($foreignColumn), $this->namingStrategy, $this->annotationParser);
-                    if ($first || $element->isCompulsory() && $index->isUnique()) {
+                    if ($first || ($element->isCompulsory() && $index->isUnique())) {
                         // First parameter for index is not nullable
                         $filterArrayCode .= '    '.var_export($localColumn, true).' => '.$element->getSafeVariableName().'->'.$targetedElement->getGetterName()."(),\n";
                     } else {
@@ -1395,9 +1374,6 @@ private function generateFindByDaoCodeForIndex(Index $index, string $beanNamespa
             }
         }
 
-        //$paramsString = implode("\n", $params);
-
-
         $methodName = $this->namingStrategy->getFindByIndexMethodName($index, $elements);
 
         $method = new MethodGenerator($methodName);

src/Utils/DirectForeignKeyMethodDescriptor.php

@@ -261,7 +261,7 @@ public function getJsonSerializeCode(): string
         } else {
             $code = <<<PHP
 \$array['$index'] = array_map(function ($class $variableName) {
-    return ${variableName}->$format;
+    return {$variableName}->$format;
 }, \$this->$getter()->toArray());
 PHP;
         }