Tools: Topology: Add echo reference for SDW speaker and jack #10387
Conversation
|
Build variants with echo reference, for both speaker and jack, just speaker, just jack, echoref but without speaker post-processing. Echo reference for jack: Echo reference for jack and speaker, no EQ and DRC. Echo reference for speaker: Echo Reference for speaker and jack, with EQ and DRC for speaker: |
singalsu
force-pushed
the
tplg_sdw_copier_echo_ref
branch
from
482b7a0 to
15a0e37
Compare
| num_input_pins 1 | ||
| num_output_pins 1 | ||
| num_input_audio_formats 1 | ||
| num_output_audio_formats 1 |
There was a problem hiding this comment.
Does the host copier need to support all output formats?
There was a problem hiding this comment.
Yep, all s16/24/32 and float are OK, I can add it. The 8-bit formats are not good for the purpose.
This patch adds an echo reference capture PCM for speaker and jack playback. The additions are normally disabled but can be enabled with build options SDW_JACK_ECHO_REF=true and/or SDW_SPK_ECHO_REF=true. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
singalsu
force-pushed
the
tplg_sdw_copier_echo_ref
branch
from
15a0e37 to
523ee9d
Compare
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
Can echo ref be always available in the topology and switch on/off by opening the PCM ?
Yep, the PCMs can be used or ignored. If there is no playback and ref capture is done, it produces silence. |
Perfect, lets do this so its available for general usage. This would need a new PCM ID. I assume this would capture playback if the playback PCM was in use ? |
3 participants
This patch adds an echo reference capture PCM for speaker and jack playback. The additions are normally disabled but can be enabled with build options SDW_JACK_ECHO_REF=true and/or SDW_SPK_ECHO_REF=true.