Skip to content

Better handle solid.lazy #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Better handle solid.lazy #325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1bc047
Better handle solid.lazy
thetarnav Dec 28, 2024
c0ac42f
Create early-turkeys-compete.md
thetarnav Dec 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/early-turkeys-compete.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@solid-devtools/debugger": patch
---

Better handle solid.lazy
Requires https://github.com/solidjs/solid/pull/2389
18 changes: 18 additions & 0 deletions packages/debugger/src/structure/walker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,24 @@ function mapOwner(

let first_owned: Solid.Owner | undefined

/*
solid.lazy(MyComponent) hoc
↳ wrap (callback returned from lazy, called as a component)
↳ memo
↳ MyComponent
*/
if (name === 'wrap' &&
typeof ((owner as Solid.Component).component as any)?.preload === 'function' &&
owner.owned &&
owner.owned.length === 1 &&
markOwnerType((first_owned = owner.owned[0]!)) === NodeType.Memo &&
first_owned.owned &&
first_owned.owned.length === 1 &&
markOwnerType((first_owned = first_owned.owned[0]!)) === NodeType.Component
) {
return mapOwner(first_owned, parent)
}

/*
Context

Expand Down
Loading