SortableProvider doesn't like "0" as an ID

[benbriedis]

I have an example here: https://stackblitz.com/edit/solidjs-templates-uekvqb
If you drag around the row with the '0' ID then a gap is not made for it in the list.
You can drop the item OK.

[martinpengellyphillips]

Thanks for the report and reproduction. I'll take a look.

[martinpengellyphillips]

From a quick look I imagine it is caused by this naive check here:

solid-dnd/src/sortable-context.tsx

Line 44 in 809014f

if (dndState.active.draggableId && dndState.active.droppableId) {

I'll fix that to be stricter (and avoid treating a 0 as a false evaluation).

[floratmin]

From a quick look I imagine it is caused by this naive check here:

solid-dnd/src/sortable-context.tsx

Line 44 in 809014f

if (dndState.active.draggableId && dndState.active.droppableId) {

I'll fix that to be stricter (and avoid treating a 0 as a false evaluation).

Yes this fix works.