Add Defector crossword support #200
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds jq dependency for parsing HTML-in-JSON-in-HTML on NextJS sites
TODO: can we continue searching through pagination?
jq was used in a single line for filtering JSON, but this can be done easily in Python and avoids adding a dependency.
Contributor
|
I sent a PR to avoid adding a dependency on jq, which was only really needed in one line: unitof#1 |
Author
|
@thisisparker bloop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dates and URL support are a soupy JSON/__NEXT_DATA__mess and I'm not very good at Python but I'm working on it! May push to a separate draft PR if I could use some help.However this adds basic support, a ladbI did it! I think.