Ability to generate hard links when Build.LinkGeneratedSources is false

[Dimagog]

Scenario is simple:

• Build.LinkGeneratedSources is false (or missing) in config
• I run plz generate
• I want it to generate hard links
• I don’t want plz build to generate any links at all

Currently generation of hard links is only possible when Build.LinkGeneratedSources is set to hard. But if I don’t want links generated during plz build, and I want hard links generated by plz generate, then I’m out of luck.

Why it’s important: soft links do not interrop with WSL on Windows.

[Dimagog]

Arguably the fix could be as simple as checking value of another config variable in this line

please/src/generate/generate.go

Line 60 in e128a94

if state.Config.Build.LinkGeneratedSources == "hard" {

[toastwaffle]

I agree with what you propose, but we don't have time to make this change. I'll happily review a PR though.

[Dimagog]

Please come up with the setting name that you like and I’ll make the change.

[toastwaffle]

Let's be verbose and explicit, and have LinkGeneratedSourcesOnBuild (boolean) and GeneratedSourcesLinkType (string, soft or hard, defaults to soft).

For now let's keep the LinkGeneratedSources field, but we should mark it as deprecated (and we can consider removing it in a future major release)

[Dimagog]

PR: #3516