[BACK-4025] Expand patient count with additional details #173
Conversation
darinkrauss
commented
Sep 16, 2025
darinkrauss
commented
- Expand patient count with additional details
- Add refresh patient count for service
- Add missing delete OAuth authorization endpoint for service
- Add missing twiist data ingestion endpoint
- https://tidepool.atlassian.net/browse/BACK-4025
- Expand patient count with additional details - Add refresh patient count for service - Add missing delete OAuth authorization endpoint for service - Add missing twiist data ingestion endpoint - https://tidepool.atlassian.net/browse/BACK-4025
ewollesen
left a comment
ewollesen
left a comment
There was a problem hiding this comment.
Just one question, not blocking per se, but should be addressed
lostlevels
left a comment
lostlevels
left a comment
There was a problem hiding this comment.
Non-blocking comments but nice to haves for future clarity.
| The count of patients that have a specific provider as a data source. | ||
| type: integer | ||
| minimum: 0 | ||
| states: |
There was a problem hiding this comment.
Nit: since the possible states are known ahead of time, I'd prefer to have the keys explicitly listed out as optional fields rather than described in the description.
There was a problem hiding this comment.
Fair enough. I am likely expanding the choice of states for a data source (which this is derived from) for the Oura work. Okay if I update this then?
reference/clinic.v1.yaml
Outdated
| description: Accepted | ||
| description: |- | ||
| An internal endpoint to refresh the patient count for this clinic. This request may or may not be processed asynchronously. | ||
| A successful response means the patient count will be refreshed shortly. |
There was a problem hiding this comment.
For my curiosity, how does the client know when the count will be refreshed? Do they just poll the patients count endpoint? There's nothing in the patient count endpoint (to my eye) that indicates the last update time for the client to know if it was refreshed or not. Might be useful to add in the future.
There was a problem hiding this comment.
I updated the comment and removed the asynchronous aspect. I also updated the response code from Accepted 202 to OK 200.
darinkrauss
dismissed stale reviews from lostlevels and ewollesen
via
89a7a49
