fix: address lock consistency violation report by FB Infer

[mojomex]

PR Type

• New Feature
• Improvement
• Bug Fix

Related Links

Description

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

• Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

• Commits are properly organized and messages are according to the guideline
• (Optional) Unit tests have been written for new behavior
• PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

• All open points are addressed and tracked via issues or tickets

CI Checks

• Build and test for PR: Required to pass before the merge.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 31.42%. Comparing base (77c2dbb) to head (4a68264).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #374      +/-   ##
==========================================
- Coverage   34.36%   31.42%   -2.95%     
==========================================
  Files         130      131       +1     
  Lines       10519    10412     -107     
  Branches     5709     3847    -1862     
==========================================
- Hits         3615     3272     -343     
- Misses       6212     6557     +345     
+ Partials      692      583     -109     

Flag	Coverage Δ
differential	31.42% <0.00%> (?)
total	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
Common	29.49% <ø> (-23.25%)	⬇️
Hesai	33.08% <0.00%> (-1.11%)	⬇️
Velodyne	39.70% <0.00%> (+0.14%)	⬆️
Continental	32.13% <0.00%> (+0.11%)	⬆️
Robosense	5.42% <0.00%> (+0.02%)	⬆️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions]

FB Infer Report

🎉 Fixed 2 bugs!

Additional details

Bug Type	Pre-existing	Fixed	Introduced
Const Refable Parameter	36	0	0
Dead Store	15	0	0
Lock Consistency Violation	1	2	0
Optional Empty Access	2	0	0
Read-only Shared Parameter	15	0	0
Uninitialized Value	14	0	0
Unnecessary Copy	5	0	0
Unnecessary Copy Assignment	12	0	0
Unnecessary Copy Assignment from Const	1	0	0
Unnecessary Copy Intermediate	39	0	0
Use After Delete	1	0	0

Download the full Infer report.