Create required nitro dirs at the daemon and container level #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emostov
reviewed
Jun 28, 2023
| ARG BIN | ||
| ARG EIF | ||
| VOLUME /run/nitro_enclaves | ||
| VOLUME /var/log/nitro_enclaves |
There was a problem hiding this comment.
Will these volumes get created when the docker image is run?
There was a problem hiding this comment.
@lrvick see the old question above
|
do you want to make another release? |
emostov
approved these changes
Jul 3, 2023
drGrove
approved these changes
Jul 3, 2023
|
@lrvick do you want to merge this? |
|
@lrvick is this still relevant or can we close it? |
|
As I recall we have hacks to work around this elsewhere, but IMO this is still the right place to do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.