From 1692c4c8cfc717c73d2f322ccdab83535918b143 Mon Sep 17 00:00:00 2001 From: Paula Meuronen Date: Fri, 6 Dec 2024 16:01:27 +0200 Subject: [PATCH 1/3] =?UTF-8?q?Viikko6:=20Teht=C3=A4v=C3=A4=206.=20Tyhj?= =?UTF-8?q?=C3=A4=20pull=20request?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index 55574dd..5ace1c5 100644 --- a/README.md +++ b/README.md @@ -47,3 +47,4 @@ Käynnistä ohjelma: python src/index.py ``` + From 6d0315a9107d0740c034ffec161eb037d6f7227e Mon Sep 17 00:00:00 2001 From: Paula Meuronen Date: Fri, 6 Dec 2024 16:26:40 +0200 Subject: [PATCH 2/3] Function generate_bibtext. Removed last extra comma. --- src/util.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/util.py b/src/util.py index 2e57d9d..1252169 100644 --- a/src/util.py +++ b/src/util.py @@ -40,7 +40,8 @@ def generate_bibtex(citations: list[Citation]): bibtex += f"@{citation.citation_type}{{{citation.citation_key},\n" for field_name, field_value in citation.fields.items(): bibtex += f"\t{field_name} = {{{field_value}}},\n" - bibtex += "}\n\n" + bibtex = bibtex[:-2] + bibtex += "\n}\n\n" return bibtex From 9ec8b96bbc1b9e910025435fbb0663975a0331cf Mon Sep 17 00:00:00 2001 From: Hanna Turunen Date: Mon, 16 Dec 2024 12:41:07 +0200 Subject: [PATCH 3/3] Testeihin muutos bibtex generoinnin muutoksen takia --- src/tests/bibtex_generation_test.py | 33 +++++++++++++++-------------- 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/src/tests/bibtex_generation_test.py b/src/tests/bibtex_generation_test.py index 144a573..14e5921 100644 --- a/src/tests/bibtex_generation_test.py +++ b/src/tests/bibtex_generation_test.py @@ -2,26 +2,27 @@ from entities.citation import Citation from util import generate_bibtex + class TestBibtexGeneration(unittest.TestCase): def setUp(self): pass def test_bibtex_generates_correctly(self): citations = [] - citations.append(Citation("article", "1", - { - "author": "1", - "title": "1", - "year": "1", - "journal": "1" - })) - citations.append(Citation("article", "2", - { - "author": "2", - "title": "2", - "year": "2", - "journal": "2" - })) + citations.append( + Citation( + "article", + "1", + {"author": "1", "title": "1", "year": "1", "journal": "1"}, + ) + ) + citations.append( + Citation( + "article", + "2", + {"author": "2", "title": "2", "year": "2", "journal": "2"}, + ) + ) bibtex = generate_bibtex(citations) @@ -29,14 +30,14 @@ def test_bibtex_generates_correctly(self): \tauthor = {1}, \ttitle = {1}, \tyear = {1}, -\tjournal = {1}, +\tjournal = {1} } @article{2, \tauthor = {2}, \ttitle = {2}, \tyear = {2}, -\tjournal = {2}, +\tjournal = {2} } """