From ecdeec9d40129e2cda35aa7ba22e44e37594c299 Mon Sep 17 00:00:00 2001 From: markgis Date: Tue, 1 Sep 2020 16:31:39 +0100 Subject: [PATCH 1/3] bumping NAN version seems to have fixed node > 12 builds --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 974bfd5..7771efd 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -23,7 +23,7 @@ include(${PROJECT_SOURCE_DIR}/node_modules/@mapbox/cmake-node-module/module.cmak add_node_module( mbgl-node INSTALL_PATH ${PROJECT_SOURCE_DIR}/lib/{node_abi}/mbgl.node - NAN_VERSION 2.10.0 + NAN_VERSION 2.14.1 EXCLUDE_NODE_ABIS 46 47 From 5d743723eca2bb412c70a6f128e6913da21ee17e Mon Sep 17 00:00:00 2001 From: markgis Date: Wed, 2 Sep 2020 16:45:45 +0100 Subject: [PATCH 2/3] build works with node 11, will try upgrading NAN to 2.14.0 --- CMakeLists.txt | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 7771efd..8b2f7de 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1,4 +1,4 @@ -cmake_minimum_required(VERSION 3.10 FATAL_ERROR) +cmake_minimum_required(VERSION 3.12 FATAL_ERROR) project("Mapbox GL Native Node Bindings" LANGUAGES CXX) cmake_policy(SET CMP0063 NEW) @@ -23,14 +23,13 @@ include(${PROJECT_SOURCE_DIR}/node_modules/@mapbox/cmake-node-module/module.cmak add_node_module( mbgl-node INSTALL_PATH ${PROJECT_SOURCE_DIR}/lib/{node_abi}/mbgl.node - NAN_VERSION 2.14.1 + NAN_VERSION 2.9.2 EXCLUDE_NODE_ABIS 46 47 48 51 59 - 67 72 79 83 From b2d82dbdcae8f21908aac04774a41d9f0a192b8e Mon Sep 17 00:00:00 2001 From: markgis Date: Thu, 3 Sep 2020 12:10:16 +0100 Subject: [PATCH 3/3] tried to bump versions of gyp, nan and latest mapbox-native but still fails on node 12 --- CMakeLists.txt | 5 ++--- package.json | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 8b2f7de..747693b 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1,4 +1,4 @@ -cmake_minimum_required(VERSION 3.12 FATAL_ERROR) +cmake_minimum_required(VERSION 3.18.2 FATAL_ERROR) project("Mapbox GL Native Node Bindings" LANGUAGES CXX) cmake_policy(SET CMP0063 NEW) @@ -23,14 +23,13 @@ include(${PROJECT_SOURCE_DIR}/node_modules/@mapbox/cmake-node-module/module.cmak add_node_module( mbgl-node INSTALL_PATH ${PROJECT_SOURCE_DIR}/lib/{node_abi}/mbgl.node - NAN_VERSION 2.9.2 + NAN_VERSION 2.14.0 EXCLUDE_NODE_ABIS 46 47 48 51 59 - 72 79 83 ) diff --git a/package.json b/package.json index bc0cc9c..f7fd113 100644 --- a/package.json +++ b/package.json @@ -15,7 +15,7 @@ "dependencies": { "@mapbox/cmake-node-module": "^1.2.0", "minimatch": "^3.0.4", - "node-pre-gyp": "^0.10.2", + "node-pre-gyp": "^0.15.0", "npm-run-all": "^4.0.2" }, "engines": {