Skip to content

NAN version #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
markgis wants to merge 3 commits into
base: master
Choose a base branch
from
Open

NAN version #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ecdeec9
bumping NAN version seems to have fixed node > 12 builds
markgis Sep 1, 2020
5d74372
build works with node 11, will try upgrading NAN to 2.14.0
markgis Sep 2, 2020
b2d82db
tried to bump versions of gyp, nan and latest mapbox-native but still…
markgis Sep 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.10 FATAL_ERROR)
cmake_minimum_required(VERSION 3.18.2 FATAL_ERROR)
project("Mapbox GL Native Node Bindings" LANGUAGES CXX)

cmake_policy(SET CMP0063 NEW)
Expand All @@ -23,15 +23,13 @@ include(${PROJECT_SOURCE_DIR}/node_modules/@mapbox/cmake-node-module/module.cmak
add_node_module(
mbgl-node
INSTALL_PATH ${PROJECT_SOURCE_DIR}/lib/{node_abi}/mbgl.node
NAN_VERSION 2.10.0
NAN_VERSION 2.14.0
EXCLUDE_NODE_ABIS
46
47
48
51
59
67
72
79
83
)
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"dependencies": {
"@mapbox/cmake-node-module": "^1.2.0",
"minimatch": "^3.0.4",
"node-pre-gyp": "^0.10.2",
"node-pre-gyp": "^0.15.0",
"npm-run-all": "^4.0.2"
},
"engines": {
Expand Down