Skip to content

Commit 4251544

Browse files
committed
Fix CI
1 parent a23a27a commit 4251544

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

.github/workflows/app-cloudrun-build.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@ jobs:
6767
SERVICE_PREFIX="${{ inputs.service-name-prefix }}"
6868
BASE_NAME="${{vars.SERVICE_NAME}}"
6969
SENTRY_AUTH_TOKEN=${{secrets.SENTRY_AUTH_TOKEN}}
70-
GITHUB_TOKEN=${{ secrets.GITHUB_TOKEN }}
7170
# Convert all GitHub vars to build args
7271
BUILD_ARGS=""
7372
for var in $(echo '${{ toJSON(vars) }}' | jq -r 'to_entries | .[] | @base64'); do
@@ -87,6 +86,6 @@ jobs:
8786
echo "Building image with args: $BUILD_ARGS"
8887

8988
IMAGE="${REPO}/${SERVICE_PREFIX:+$SERVICE_PREFIX-}${BASE_NAME}"
90-
eval docker build -t ${IMAGE}:${SHA} . --file ${{ inputs.dockerfile }} --secret github_token=${GITHUB_TOKEN} ${BUILD_ARGS}
89+
eval docker build -t ${IMAGE}:${SHA} . --file ${{ inputs.dockerfile }} ${BUILD_ARGS}
9190
docker push ${IMAGE}:${SHA}
9291
echo "image_tag=${IMAGE}:${SHA}" >> $GITHUB_OUTPUT

Dockerfile

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,7 @@ WORKDIR /app
99
COPY package.json package-lock.json* ./
1010

1111
# Install dependencies with GitHub token authentication
12-
RUN --mount=type=secret,id=github_token \
13-
npm config set @tokens-studio:registry https://npm.pkg.github.com && \
14-
npm config set //npm.pkg.github.com/:_authToken=$(cat /run/secrets/github_token) && \
12+
RUN npm config set @tokens-studio:registry https://npm.pkg.github.com && \
1513
npm install --no-audit --no-fund
1614

1715
# Copy source files

0 commit comments

Comments
 (0)