Implement IgnoreClosuresInFunctions (#51)
#64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
Per #51, this implements a configurable option to ignore unwrapped errors within closures within configured functions.
I'm not sure if this is the best way to implement this; however, it does seem to work fine against a large project I'm working on. Upon reflecting, I think it might actually be better to instead check the surrounding function by default and check if it wraps errors returned from the closure function; however, this was an afterthought. I'd certainly appreciate some input on the idea!
Upon trying to test my solution, I ran into dependency issues, and was forced to upgrade them. Please feel free to drop or modify the dependency updates as you see fit.
I'd appreciate any feedback on this, and will happily make changes as needed :) Thanks again for such a useful tool!