Modernize gem #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open

seuros wants to merge 2 commits into trailblazer:master from seuros:master

.github/workflows/ci.yml

            
                      Original file line number
                      Diff line number
                      Diff line change
                  
    @@ -5,12 +5,12 @@ jobs:
  
        strategy:

          fail-fast: false

          matrix:

            ruby: [2.6, 2.7, '3.0', '3.1', '3.2', 'jruby']

            ruby: [2.6, 2.7, "3.0", "3.2", "3.4", "jruby"]

        runs-on: ubuntu-latest

        steps:

        - uses: actions/checkout@v3

        - uses: ruby/setup-ruby@v1

          with:

            ruby-version: ${{ matrix.ruby }}

            bundler-cache: true

        - run: bundle exec rake

          - uses: actions/checkout@v4

          - uses: ruby/setup-ruby@v1

            with:

              ruby-version: ${{ matrix.ruby }}

              bundler-cache: true

          - run: bundle exec rake

Gemfile

-Original file line number
+Diff line change
@@ -1,3 +1,4 @@
+    # frozen_string_literal: true
     source "https://rubygems.org"
     # Specify your gem's dependencies in trailblazer-developer.gemspec
@@ Expand All / @@ -13,3 +14,4 @@ gemspec @@
     gem "benchmark-ips"
+    gem "rubocop", require: false

Rakefile

-Original file line number
+Diff line change
@@ -1,3 +1,4 @@
+    # frozen_string_literal: true
     require "bundler/gem_tasks"
     require "rake/testtask"
@@ Expand Down @@

bin/console

-Original file line number
+Diff line change
@@ -1,4 +1,5 @@
     #!/usr/bin/env ruby
+    # frozen_string_literal: true
     require "bundler/setup"
     require "trailblazer/developer"
@@ Expand Down @@

lib/trailblazer/developer.rb

-Original file line number
+Diff line change
@@ -1,3 +1,4 @@
+    # frozen_string_literal: true
     require "trailblazer/developer/version"
     module Trailblazer
@@ Expand Down @@

lib/trailblazer/developer/debugger.rb

-Original file line number
+Diff line change
@@ -1,3 +1,4 @@
+    # frozen_string_literal: true
     module Trailblazer
       module Developer
         # Code in Debugger is only executed if the user wants to render the stack.
@@ Expand Down @@

lib/trailblazer/developer/debugger/normalizer.rb

-Original file line number
+Diff line change
@@ -1,3 +1,4 @@
+    # frozen_string_literal: true
     module Trailblazer
       module Developer
         module Debugger
@@ Expand Down @@

lib/trailblazer/developer/introspect.rb

-Original file line number
+Diff line change
@@ -1,3 +1,4 @@
+    # frozen_string_literal: true
     module Trailblazer
       module Developer
         module Introspect
@@ Expand Down @@

lib/trailblazer/developer/introspect/graph.rb

-Original file line number
+Diff line change
@@ -1,3 +1,4 @@
+    # frozen_string_literal: true
     # NOTE: The Graph API might get deprecated and replaced.
     module Trailblazer
       module Developer
@@ Expand Down @@

lib/trailblazer/developer/render/circuit.rb

-Original file line number
+Diff line change
@@ -1,3 +1,4 @@
+    # frozen_string_literal: true
     module Trailblazer
       module Developer
         module_function
@@ Expand Down @@

lib/trailblazer/developer/render/linear.rb

-Original file line number
+Diff line change
@@ -1,3 +1,4 @@
+    # frozen_string_literal: true
     module Trailblazer
       # Operation-specific circuit rendering. This is optimized for a linear railway circuit.
       #
@@ Expand Down @@

lib/trailblazer/developer/render/task_wrap.rb

-Original file line number
+Diff line change
@@ -1,3 +1,4 @@
+    # frozen_string_literal: true
     module Trailblazer
       module Developer
         module Render
@@ Expand Down @@

lib/trailblazer/developer/trace.rb

-Original file line number
+Diff line change
@@ -1,3 +1,4 @@
+    # frozen_string_literal: true
     module Trailblazer::Developer
       module Trace
         class << self
@@ Expand Down @@

lib/trailblazer/developer/trace/node.rb

-Original file line number
+Diff line change
@@ -1,3 +1,4 @@
+    # frozen_string_literal: true
     module Trailblazer
       module Developer
         module Trace
@@ Expand Down @@

lib/trailblazer/developer/trace/parent_map.rb

-Original file line number
+Diff line change
@@ -1,3 +1,4 @@
+    # frozen_string_literal: true
     module Trailblazer
       module Developer
         module Trace
@@ Expand Down @@

lib/trailblazer/developer/trace/present.rb

-Original file line number
+Diff line change
@@ -1,4 +1,5 @@
-    require "hirb"
+    # frozen_string_literal: true
+    require "hirber"
     module Trailblazer::Developer
       module Trace
@@ Expand Down @@

lib/trailblazer/developer/trace/snapshot.rb

-Original file line number
+Diff line change
@@ -1,3 +1,4 @@
+    # frozen_string_literal: true
     module Trailblazer::Developer
       module Trace
         # WARNING:  the interfaces here are subject to change, we're still experimenting
@@ Expand Down @@

lib/trailblazer/developer/trace/snapshot/value.rb

-Original file line number
+Diff line change
@@ -1,3 +1,4 @@
+    # frozen_string_literal: true
     module Trailblazer::Developer
       module Trace
         class Snapshot
@@ Expand Down @@

lib/trailblazer/developer/trace/snapshot/versions.rb

-Original file line number
+Diff line change
@@ -1,3 +1,4 @@
+    # frozen_string_literal: true
     module Trailblazer::Developer
       module Trace
         class Snapshot
@@ Expand Down @@

lib/trailblazer/developer/trace/stack.rb

-Original file line number
+Diff line change
@@ -1,3 +1,4 @@
+    # frozen_string_literal: true
     module Trailblazer
       module Developer
         module Trace
@@ Expand Down @@

lib/trailblazer/developer/version.rb

-Original file line number
+Diff line change
@@ -1,3 +1,4 @@
+    # frozen_string_literal: true
     module Trailblazer
       module Version
         module Developer
@@ Expand Down @@

lib/trailblazer/developer/wtf.rb

-Original file line number
+Diff line change
@@ -1,3 +1,4 @@
+    # frozen_string_literal: true
     module Trailblazer::Developer
       module_function
@@ Expand Down @@

lib/trailblazer/developer/wtf/renderer.rb

-Original file line number
+Diff line change
@@ -1,3 +1,4 @@
+    # frozen_string_literal: true
     module Trailblazer::Developer
       module Wtf
@@ Expand Down @@

test/benchmark/hash.rb

Original file line number	Diff line number	Diff line change
		@@ -1,3 +1,4 @@
		# frozen_string_literal: true
		require "benchmark/ips"


Expand Down

test/benchmark/lib/deprecated_snapshot.rb

-Original file line number
+Diff line change
@@ -1,3 +1,4 @@
+    # frozen_string_literal: true
     module Trailblazer::Developer
       module Trace
         class Snapshot
@@ Expand Down @@

test/benchmark/snapshot.rb

-Original file line number
+Diff line change
@@ -1,3 +1,4 @@
+    # frozen_string_literal: true
     require "test_helper"
     require_relative "lib/deprecated_snapshot"
     require_relative "../trace_test"
@@ Expand Down @@

test/docs/developer_test.rb

-Original file line number
+Diff line change
@@ -1,3 +1,4 @@
+    # frozen_string_literal: true
     require "test_helper"
     class DocsDeveloperTest < Minitest::Spec
@@ Expand Down @@

test/docs/graph_test.rb

-Original file line number
+Diff line change
@@ -1,3 +1,4 @@
+    # frozen_string_literal: true
     require "test_helper"
     class GraphTest < Minitest::Spec
@@ Expand Down @@

test/graph_test.rb

-Original file line number
+Diff line change
@@ -1,3 +1,4 @@
+    # frozen_string_literal: true
     require "test_helper"
     class IntrospectGraphTest < Minitest::Spec
@@ Expand Down @@

test/render_linear_test.rb

-Original file line number
+Diff line change
@@ -1,3 +1,4 @@
+    # frozen_string_literal: true
     require "test_helper"
     class RenderLinearTest < Minitest::Spec
@@ Expand Down @@

test/render_task_wrap_test.rb

-Original file line number
+Diff line change
@@ -1,3 +1,4 @@
+    # frozen_string_literal: true
     require "test_helper"
     class RenderTaskWrapTest < Minitest::Spec
@@ Expand Down @@

test/render_test.rb

-Original file line number
+Diff line change
@@ -1,3 +1,4 @@
+    # frozen_string_literal: true
     require "test_helper"
     class RenderCircuitTest < Minitest::Spec
@@ Expand Down @@

test/test_helper.rb

-Original file line number
+Diff line change
@@ -1,3 +1,4 @@
+    # frozen_string_literal: true
     $LOAD_PATH.unshift File.expand_path("../lib", __dir__)
     require "trailblazer/developer"
@@ Expand All / @@ -17,6 +18,18 @@ @@
       Implementing = T.def_tasks(:b, :e, :B, :C)
+      # Helper to check hash inspect output across Ruby versions
+      # Ruby >= 3.4 uses {:key=>value} syntax, older versions use {key: value}
+      def assert_hash_inspect(actual, expected_old_syntax)
+        if RUBY_VERSION >= "3.4"
+          # Convert old syntax to new syntax for comparison
+          expected_new_syntax = expected_old_syntax.gsub(/(\w+): /, ':\1=>')
+          assert_equal actual, expected_new_syntax
+        else
+          assert_equal actual, expected_old_syntax
+        end
+      end
       let(:flat_activity) do
         Class.new(Trailblazer::Activity::Path) do
           step task: Implementing.method(:B), id: :B
@@ Expand Down @@

test/trace/debugger_test.rb

-Original file line number
+Diff line change
@@ -1,3 +1,4 @@
+    # frozen_string_literal: true
     require "test_helper"
     class DebuggerTest < Minitest::Spec
@@ Expand Down @@

test/trace/node_test.rb

-Original file line number
+Diff line change
@@ -1,3 +1,4 @@
+    # frozen_string_literal: true
     require "test_helper"
     class TraceNodeTest < Minitest::Spec
@@ Expand Down @@

test/trace/normalizer_test.rb

-Original file line number
+Diff line change
@@ -1,3 +1,4 @@
+    # frozen_string_literal: true
     require "test_helper"
     class TraceNormalizerTest < Minitest::Spec
@@ Expand Down @@

test/trace/present_test.rb

-Original file line number
+Diff line change
@@ -1,3 +1,4 @@
+    # frozen_string_literal: true
     require "test_helper"
     # Test {Trace::Present.call}
@@ Expand Down @@

test/trace/stack_test.rb

-Original file line number
+Diff line change
@@ -1,3 +1,4 @@
+    # frozen_string_literal: true
     require "test_helper"
     class StackTest < Minitest::Spec
@@ Expand Down @@

test/trace/wtf_test.rb

            
                      Original file line number
                      Diff line number
                      Diff line change
                  
    @@ -1,3 +1,4 @@
  
    # frozen_string_literal: true

    require "test_helper"

    class TraceWtfTest < Minitest::Spec

    @@ -86,7 +87,7 @@ def <<(value)
  
        # test returned values for #wtf?

        assert_equal returned_args.size, 5

        assert_equal returned_args[0].inspect, %(#<Trailblazer::Activity::End semantic=:failure>)

        assert_equal returned_args[1][0].inspect, %({:seq=>[:a, :b, :c], :c=>false})

        assert_hash_inspect returned_args[1][0].inspect, "{seq: [:a, :b, :c], c: false}"

        assert_equal returned_args[1][1].class, Hash # flow_options

        assert_equal returned_args[2].inspect, %({}) # circuit_options

        assert_equal returned_args[3].chomp, output.chomp # fourth returned value is the trace output.

    @@ -132,7 +133,7 @@ def <<(value)
  
        assert_equal captured_output.chomp, %(Nodes: 15)

        assert_equal signal.inspect, %(#<Trailblazer::Activity::End semantic=:success>)

        assert_equal ctx.inspect, %({:seq=>[:a, :b, :c, :cc, :bb, :aa]})

        assert_hash_inspect ctx.inspect, "{seq: [:a, :b, :c, :cc, :bb, :aa]}"

        assert_equal circuit_options, {}

        assert_equal output, captured_output.chomp

        assert_equal returned_present_args, ["additional", "returned", "args"]

test/trace_test.rb

            
                      Original file line number
                      Diff line number
                      Diff line change
                  
    @@ -1,3 +1,4 @@
  
    # frozen_string_literal: true

    require "test_helper"

    # Test {Trace.call} and {Trace::Present.call}

    @@ -7,7 +8,7 @@ class TraceTest < Minitest::Spec
  
        assert_equal signal.class.inspect, %{Trailblazer::Activity::End}

        assert_equal ctx.inspect, %{{:seq=>[:B, :C]}}

        assert_hash_inspect ctx.inspect, "{seq: [:B, :C]}"

        assert_equal flow_options[:flow].inspect, %{true}

        output = Dev::Trace::Present.(stack)

    @@ -27,7 +28,7 @@ class TraceTest < Minitest::Spec
  
        assert_equal signal.class.inspect, %{Trailblazer::Activity::End}

        assert_equal ctx.inspect, %{{:seq=>[:B, :C]}}

        assert_hash_inspect ctx.inspect, "{seq: [:B, :C]}"

        assert_equal flow_options[:flow].inspect, %{true}

        output = Dev::Trace::Present.(stack)

    @@ -190,7 +191,7 @@ def authorize(ctx, current_user:, seq:, **)
  
        assert_equal Trailblazer::Developer::Trace::Snapshot.snapshot_ctx_for(stack[11], stack_object.variable_versions), # asserted snapshot is for {After(:model)}.

          {

            current_user: {value: current_user.inspect, has_changed: false},

            params:       {value: "{:name=>\"Q & I\"}", has_changed: false},

            params:       {value: RUBY_VERSION >= "3.4" ? "{:name=>\"Q & I\"}" : "{name: \"Q & I\"}", has_changed: false},

            seq:          {value: "[:authenticate, :authorize, :model]", has_changed: true},

            model:        {value: "Object", has_changed: true}

          }

trailblazer-developer.gemspec

-Original file line number
+Diff line change
@@ -1,3 +1,4 @@
+    # frozen_string_literal: true
     lib = File.expand_path("lib", __dir__)
     $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
     require "trailblazer/developer/version"
@@ Expand Down Expand Up / @@ -25,5 +26,5 @@ Gem::Specification.new do |spec| @@
       spec.add_development_dependency "trailblazer-operation", ">= 0.10.0"
       spec.add_dependency "trailblazer-activity-dsl-linear", ">= 1.2.0", "< 1.3.0"
-      spec.add_dependency "hirb"
+      spec.add_dependency "hirber"
     end

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Modernize gem #50

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Uh oh!

Modernize gem #50

Are you sure you want to change the base?

Uh oh!

Modernize gem #50

Uh oh!

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Uh oh!