Skip to content

Parent might be an empty Entry #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edalzell merged 1 commit into from
Mar 7, 2025
Merged

Parent might be an empty Entry #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/Fieldtypes/Review.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,18 @@ public function preload()
return [];
}

// when it's a new entry the "parent" is the collection
// when it's a new entry the "parent" might be a collection
// in this case, we can't show it anyway so return empty
if ($entry instanceof Collection) {
return [];
}

// if there's a computed field in the entry's collection that uses augmentation,
// this maybe be an empty entry, without an id
if (is_null($entry->id())) {
return [];
}

return ['site_url' => URL::reviewUrl($entry)];
}
}