Skip to content

Commit 5f237db

Browse files
committed
Coderabbit fixes
1 parent 39dee29 commit 5f237db

File tree

3 files changed

+18
-7
lines changed
  • apps/webapp/app/routes
    • _app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.logs
    • _app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.models._index
    • storybook.animated-panel

3 files changed

+18
-7
lines changed

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.logs/route.tsx

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ import {
3737
ResizablePanel,
3838
ResizablePanelGroup,
3939
collapsibleHandleClassName,
40+
useFrozenValue,
4041
} from "~/components/primitives/Resizable";
4142
import { Button } from "~/components/primitives/Buttons";
4243
import { FEATURE_FLAG, validateFeatureFlagValue } from "~/v3/featureFlags";
@@ -404,6 +405,11 @@ function LogsList({
404405
return accumulatedLogs.find((log) => log.id === selectedLogId);
405406
}, [selectedLogId, accumulatedLogs]);
406407

408+
const frozenLogId = useFrozenValue(selectedLogId);
409+
const frozenLog = useFrozenValue(selectedLog);
410+
const displayLogId = selectedLogId ?? frozenLogId;
411+
const displayLog = selectedLog ?? frozenLog;
412+
407413
const updateUrlWithLog = useCallback((logId: string | undefined) => {
408414
const url = new URL(window.location.href);
409415
if (logId) {
@@ -473,7 +479,7 @@ function LogsList({
473479
collapseAnimation={RESIZABLE_PANEL_ANIMATION}
474480
>
475481
<div className="h-full" style={{ minWidth: 430 }}>
476-
{selectedLogId && (
482+
{displayLogId && (
477483
<Suspense
478484
fallback={
479485
<div className="flex h-full items-center justify-center">
@@ -482,8 +488,8 @@ function LogsList({
482488
}
483489
>
484490
<LogDetailView
485-
logId={selectedLogId}
486-
initialLog={selectedLog}
491+
logId={displayLogId}
492+
initialLog={displayLog}
487493
onClose={handleClosePanel}
488494
searchTerm={list.searchTerm}
489495
/>

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.models._index/route.tsx

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ import {
4141
ResizablePanel,
4242
ResizablePanelGroup,
4343
collapsibleHandleClassName,
44+
useFrozenValue,
4445
} from "~/components/primitives/Resizable";
4546
import { SearchInput } from "~/components/primitives/SearchInput";
4647
import { Switch } from "~/components/primitives/Switch";
@@ -1096,6 +1097,8 @@ export default function ModelsPage() {
10961097
const [showAllDetails, setShowAllDetails] = useState(false);
10971098
const [compareOpen, setCompareOpen] = useState(false);
10981099
const [selectedModel, setSelectedModel] = useState<ModelCatalogItem | null>(null);
1100+
const frozenModel = useFrozenValue(selectedModel);
1101+
const displayModel = selectedModel ?? frozenModel;
10991102

11001103
const popularMap = useMemo(() => {
11011104
const map = new Map<string, PopularModel>();
@@ -1181,10 +1184,10 @@ export default function ModelsPage() {
11811184
collapseAnimation={RESIZABLE_PANEL_ANIMATION}
11821185
>
11831186
<div className="h-full" style={{ minWidth: 420 }}>
1184-
{selectedModel && (
1187+
{displayModel && (
11851188
<ModelDetailPanel
1186-
key={selectedModel.friendlyId}
1187-
model={selectedModel}
1189+
key={displayModel.friendlyId}
1190+
model={displayModel}
11881191
organizationId={organizationId}
11891192
projectId={projectId}
11901193
environmentId={environmentId}

apps/webapp/app/routes/storybook.animated-panel/route.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,9 @@ export default function Story() {
156156
className="overflow-hidden"
157157
collapsible
158158
collapsed={!show}
159-
onCollapseChange={() => {}}
159+
onCollapseChange={(isCollapsed) => {
160+
if (isCollapsed) setSelectedItem(null);
161+
}}
160162
collapsedSize="0px"
161163
collapseAnimation={RESIZABLE_PANEL_ANIMATION}
162164
>

0 commit comments

Comments
 (0)