Fix for deletion logic and tighter schema

Author: matt-aitken

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.errors.$fingerprint/route.tsx

@@ -80,20 +80,20 @@ export const meta: MetaFunction<typeof loader> = ({ data }) => {
 const actionSchema = z.discriminatedUnion("action", [
   z.object({
     action: z.literal("resolve"),
-    taskIdentifier: z.string(),
+    taskIdentifier: z.string().min(1),
     resolvedInVersion: z.string().optional(),
   }),
   z.object({
     action: z.literal("ignore"),
-    taskIdentifier: z.string(),
-    duration: z.coerce.number().optional(),
-    occurrenceRate: z.coerce.number().optional(),
-    totalOccurrences: z.coerce.number().optional(),
+    taskIdentifier: z.string().min(1),
+    duration: z.coerce.number().positive().optional(),
+    occurrenceRate: z.coerce.number().positive().optional(),
+    totalOccurrences: z.coerce.number().positive().optional(),
     reason: z.string().optional(),
   }),
   z.object({
     action: z.literal("unresolve"),
-    taskIdentifier: z.string(),
+    taskIdentifier: z.string().min(1),
   }),
 ]);
 

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.errors/route.tsx

@@ -17,6 +17,7 @@ import { ErrorAlertChannelPresenter } from "~/presenters/v3/ErrorAlertChannelPre
 import { findProjectBySlug } from "~/models/project.server";
 import { findEnvironmentBySlug } from "~/models/runtimeEnvironment.server";
 import { requireUserId } from "~/services/session.server";
+import { env } from "~/env.server";
 import { EnvironmentParamSchema, v3ErrorsConnectToSlackPath } from "~/utils/pathBuilder";
 import {
   type CreateAlertChannelOptions,
@@ -137,9 +138,18 @@ export const action = async ({ request, params }: ActionFunctionArgs) => {
     processedChannelIds.add(channel.id);
   }
 
+  const editableTypes = new Set<string>(["WEBHOOK"]);
+  if (env.ALERT_FROM_EMAIL !== undefined && env.ALERT_RESEND_API_KEY !== undefined) {
+    editableTypes.add("EMAIL");
+  }
+  if (slackIntegrationId) {
+    editableTypes.add("SLACK");
+  }
+
   const channelsToDelete = existingChannels.filter(
     (ch) =>
       !processedChannelIds.has(ch.id) &&
+      editableTypes.has(ch.type) &&
       ch.alertTypes.length === 1 &&
       ch.alertTypes[0] === "ERROR_GROUP"
   );